Skip to content

feat: Add Rokt close implementation#19

Merged
jamesnrokt merged 1 commit into
developmentfrom
feat/SQDSDKS-7445-rokt-close
Jul 15, 2025
Merged

feat: Add Rokt close implementation#19
jamesnrokt merged 1 commit into
developmentfrom
feat/SQDSDKS-7445-rokt-close

Conversation

@jamesnrokt

Copy link
Copy Markdown
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Add Rokt close implementation

Testing Plan

  • N/A

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copilot AI review requested due to automatic review settings July 14, 2025 13:54
@jamesnrokt jamesnrokt requested a review from a team as a code owner July 14, 2025 13:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a close method implementation for the Rokt kit to cleanly shut down the SDK.

  • Introduces - (MPKitExecStatus *)close in MPKitRokt.m
  • Calls [Rokt close] and returns a success status
Comments suppressed due to low confidence (2)

mParticle-Rokt/MPKitRokt.m:418

  • The new close method isn't declared in the MPKitRokt.h header, so it won't be exposed to callers. Please add its declaration to the kit's public interface.
- (MPKitExecStatus *)close {

mParticle-Rokt/MPKitRokt.m:418

  • [nitpick] There's no test coverage for the new close implementation. Consider adding a unit test to verify that [Rokt close] is called and the MPKitExecStatus is returned correctly.
- (MPKitExecStatus *)close {

@jamesnrokt jamesnrokt merged commit 4d5bf19 into development Jul 15, 2025
4 checks passed
@jamesnrokt jamesnrokt deleted the feat/SQDSDKS-7445-rokt-close branch July 15, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants