Skip to content

chore: Add PR notification#20

Merged
jamesnrokt merged 1 commit into
developmentfrom
chore/pr-notification
Jul 15, 2025
Merged

chore: Add PR notification#20
jamesnrokt merged 1 commit into
developmentfrom
chore/pr-notification

Conversation

@jamesnrokt

Copy link
Copy Markdown
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Add notification after PR completes

Testing Plan

  • N/A

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

  • N/A

Copilot AI review requested due to automatic review settings July 14, 2025 14:19
@jamesnrokt jamesnrokt requested a review from a team as a code owner July 14, 2025 14:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a Google Chat notification system that triggers when pull requests are opened, along with workflow concurrency controls and necessary permissions for the GitHub Actions workflow.

  • Adds concurrency control to prevent multiple workflow runs for the same PR
  • Configures required permissions for the workflow to access GitHub resources
  • Implements a notification job that sends PR updates to Google Chat
Comments suppressed due to low confidence (1)

.github/workflows/pull-request.yml:53

  • [nitpick] The secret name 'GCHAT_PRS_WEBHOOK' uses inconsistent naming with a mix of abbreviations. Consider using a more descriptive name like 'GOOGLE_CHAT_PR_WEBHOOK' for better clarity.
      gchat_webhook: ${{ secrets.GCHAT_PRS_WEBHOOK }}

Comment thread .github/workflows/pull-request.yml

@BrandonStalnaker BrandonStalnaker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesnrokt jamesnrokt merged commit 172807c into development Jul 15, 2025
5 checks passed
@jamesnrokt jamesnrokt deleted the chore/pr-notification branch July 15, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants