Skip to content

feat: Update Hashed Email for Rokt#23

Merged
BrandonStalnaker merged 3 commits into
developmentfrom
feat/SQDSDKS-7555-Handle-Hashed-Email-For-RoktPart-2
Jul 30, 2025
Merged

feat: Update Hashed Email for Rokt#23
BrandonStalnaker merged 3 commits into
developmentfrom
feat/SQDSDKS-7555-Handle-Hashed-Email-For-RoktPart-2

Conversation

@BrandonStalnaker

Copy link
Copy Markdown
Collaborator

Summary

Updated according to new specs
(1 is handled in the core sdk)

  1. If other is a current identity, and the developer passes emailsha256 attribute with a different value from other identity to selectPlacements, log a warning to the user, and call identify with other using the value from emailsha256
  2. Never remove other from the attributes passed to selectPlacements because it's considered a normal attribute
  3. If email identity exists on the user, and emailsha256 attribute is passed to selectPlacements, do not send email attribute to the selectPlacements call. OR if email identity and other identity exist on the user, only pass emailsha256 attribute with the value from other identity

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested in simulator and with new unit tests

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Jul 30, 2025
@BrandonStalnaker BrandonStalnaker requested a review from a team as a code owner July 30, 2025 18:05

@Mansi-mParticle Mansi-mParticle left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread mParticle-Rokt/MPKitRokt.m
Comment thread mParticle-Rokt/MPKitRokt.m
Comment thread mParticle_RoktTests/mParticle_RoktTests.m
Comment thread mParticle_RoktTests/mParticle_RoktTests.m Outdated
rmi22186
rmi22186 previously approved these changes Jul 30, 2025

@rmi22186 rmi22186 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after accepting the commit suggestions.

@BrandonStalnaker BrandonStalnaker merged commit 29fe2db into development Jul 30, 2025
5 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/SQDSDKS-7555-Handle-Hashed-Email-For-RoktPart-2 branch July 30, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants