feat: create no location target for rokt kit#34
Closed
nickolas-dimitrakas wants to merge 8 commits into
Closed
Conversation
nickolas-dimitrakas
changed the title
thomson-t
reviewed
Sep 2, 2025
| objc.source_files = 'mParticle-Rokt/*.{h,m}' | ||
| objc.public_header_files = 'mParticle-Rokt/*.h' | ||
| objc.dependency 'mParticle-Apple-SDK/mParticleNoLocation', '~> 8.0' | ||
| objc.dependency 'Rokt-Widget', '~> 4.10' |
Collaborator
There was a problem hiding this comment.
It would be nice to extract this version into a variable and reuse it so that we don't have to change multiple places when upgrading the version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mParticle-Rokt-NoLocationlibrary product alongside the default integration, giving developers the option to integrate without CoreLocation dependencies. UpdatedPackage.swiftandpodspecaccordingly to support both variants while keeping dependencies consistent.Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)