Rename variables, update test name

Author: rmi22186

src/Rokt-Kit.js

@@ -22,7 +22,7 @@ var constructor = function () {
     var EMAIL_KEY = 'email';
 
     // Dynamic identity type for Rokt's emailsha256 identity value which MP doesn't natively support - will be set during initialization
-    var MAPPED_EMAIL_SHA256_IDENTITY;
+    var mappedEmailSha256Key;
 
     self.name = name;
     self.moduleId = moduleId;
@@ -91,7 +91,7 @@ var constructor = function () {
         // Set dynamic OTHER_IDENTITY based on server settings
         // Convert to lowercase since server sends TitleCase (e.g., 'Other' -> 'other')
         if (settings.hashedEmailUserIdentityType) {
-            MAPPED_EMAIL_SHA256_IDENTITY =
+            mappedEmailSha256Key =
                 settings.hashedEmailUserIdentityType.toLowerCase();
         }
 
@@ -178,16 +178,16 @@ var constructor = function () {
 
     function replaceOtherIdentityWithEmailsha256(userIdentities) {
         var newUserIdentities = mergeObjects({}, userIdentities || {});
-        if (userIdentities.hasOwnProperty(MAPPED_EMAIL_SHA256_IDENTITY)) {
+        if (userIdentities.hasOwnProperty(mappedEmailSha256Key)) {
             newUserIdentities[EMAIL_SHA256_KEY] =
-                userIdentities[MAPPED_EMAIL_SHA256_IDENTITY];
-            delete newUserIdentities[MAPPED_EMAIL_SHA256_IDENTITY];
+                userIdentities[mappedEmailSha256Key];
+            delete newUserIdentities[mappedEmailSha256Key];
         }
 
         return newUserIdentities;
     }
 
-    function sanitizeIdentities(_data) {
+    function sanitizeEmailIdentities(_data) {
         var data = mergeObjects({}, _data || {});
         if (_data.hasOwnProperty(EMAIL_SHA256_KEY)) {
             delete data[EMAIL_KEY];
@@ -255,7 +255,7 @@ var constructor = function () {
         );
 
         var selectPlacementsOptions = mergeObjects(options, {
-            attributes: sanitizeIdentities(selectPlacementsAttributes),
+            attributes: sanitizeEmailIdentities(selectPlacementsAttributes),
         });
 
         return self.launcher.selectPlacements(selectPlacementsOptions);

test/src/tests.js

@@ -1323,7 +1323,7 @@ describe('Rokt Forwarder', () => {
                 );
             });
 
-            it('should pass the attribute other in selectPlacements directly to Rokt', async () => {
+            it('should pass the attribute `other` in selectPlacements directly to Rokt', async () => {
                 window.mParticle.Rokt.filters = {
                     userAttributeFilters: [],
                     filterUserAttributes: function (attributes) {