Skip to content

Commit 58f6896

Browse files
Apply suggestions from code review
Co-authored-by: Robert Ing <ring@mparticle.com>
1 parent fbe8f1e commit 58f6896

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

test/src/tests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1853,7 +1853,7 @@ describe('Rokt Forwarder', () => {
18531853
});
18541854

18551855
describe('#parseSettingsString', () => {
1856-
it('should parse a settings string', () => {
1856+
it('should parse null values in a settings string appropriately', () => {
18571857
const settingsString =
18581858
'[{&quot;jsmap&quot;:null,&quot;map&quot;:&quot;f.name&quot;,&quot;maptype&quot;:&quot;UserAttributeClass.Name&quot;,&quot;value&quot;:&quot;firstname&quot;},{&quot;jsmap&quot;:null,&quot;map&quot;:&quot;last_name&quot;,&quot;maptype&quot;:&quot;UserAttributeClass.Name&quot;,&quot;value&quot;:&quot;lastname&quot;}]';
18591859

@@ -1875,7 +1875,7 @@ describe('Rokt Forwarder', () => {
18751875
]);
18761876
});
18771877

1878-
it('should parse a settings string with a stringified number value correctly', () => {
1878+
it('should convert jmap and map number values to stringified numbers when parsed', () => {
18791879
const settingsString =
18801880
'[{&quot;jsmap&quot;:&quot;-1484452948&quot;,&quot;map&quot;:&quot;-5208850776883573773&quot;,&quot;maptype&quot;:&quot;EventClass.Id&quot;,&quot;value&quot;:&quot;abc&quot;},{&quot;jsmap&quot;:&quot;1838502119&quot;,&quot;map&quot;:&quot;1324617889422969328&quot;,&quot;maptype&quot;:&quot;EventClass.Id&quot;,&quot;value&quot;:&quot;bcd&quot;},{&quot;jsmap&quot;:&quot;-355458063&quot;,&quot;map&quot;:&quot;5878452521714063084&quot;,&quot;maptype&quot;:&quot;EventClass.Id&quot;,&quot;value&quot;:&quot;card_viewed_test&quot;}]';
18811881

0 commit comments

Comments
 (0)