test: cover denylisted identity attributes

Author: rmi22186

src/Rokt-Kit.ts

@@ -468,18 +468,14 @@ function isSelectPlacementsAttributePersistenceDenied(key: string): boolean {
 function removeSelectPlacementsAttributePersistenceDeniedAttributes(
   attributes: Record<string, unknown> | null | undefined,
 ): Record<string, unknown> {
-  const filteredAttributes: Record<string, unknown> = {};
   const sourceAttributes = attributes || {};
-  const attributeKeys = Object.keys(sourceAttributes);
 
-  for (let i = 0; i < attributeKeys.length; i++) {
-    const key = attributeKeys[i];
+  return Object.keys(sourceAttributes).reduce((filteredAttributes: Record<string, unknown>, key) => {
     if (!isSelectPlacementsAttributePersistenceDenied(key)) {
       filteredAttributes[key] = sourceAttributes[key];
     }
-  }
-
-  return filteredAttributes;
+    return filteredAttributes;
+  }, {});
 }
 
 function generateIntegrationName(customIntegrationName?: string): string {
@@ -1272,12 +1268,9 @@ class RoktKit implements KitInterface {
   }
 
   public setUserAttribute(key: string, value: unknown): string {
-    if (isSelectPlacementsAttributePersistenceDenied(key)) {
-      this.userAttributes = removeSelectPlacementsAttributePersistenceDeniedAttributes(this.userAttributes);
-      return 'Successfully set user attribute for forwarder: ' + name;
+    if (!isSelectPlacementsAttributePersistenceDenied(key)) {
+      this.userAttributes[key] = value;
     }
-
-    this.userAttributes[key] = value;
     return 'Successfully set user attribute for forwarder: ' + name;
   }
 

test/src/tests.spec.ts

@@ -3106,6 +3106,29 @@ describe('Rokt Forwarder', () => {
       });
       expect((window as any).mParticle.forwarder.filters.filteredUser.getMPID()).toBe('123');
     });
+
+    it('should not cache denylisted commerce attributes from the filtered user', () => {
+      (window as any).mParticle.forwarder.onUserIdentified({
+        getAllUserAttributes: function () {
+          return {
+            confirmationRef: 'previous-order',
+            currency: 'USD',
+            paymentServiceProvider: 'test-provider',
+            'test-attribute': 'test-value',
+          };
+        },
+        getMPID: function () {
+          return '123';
+        },
+        getUserIdentities: function () {
+          return { userIdentities: {} };
+        },
+      });
+
+      expect((window as any).mParticle.forwarder.userAttributes).toEqual({
+        'test-attribute': 'test-value',
+      });
+    });
   });
 
   describe('#workspaceIdSync', () => {