refactor: Remove unused ROKT_EXTENSIONS and simplify extension extraction logic

Author: alexs-mparticle

src/Rokt-Kit.js

@@ -16,13 +16,6 @@
 var name = 'Rokt';
 var moduleId = 181;
 
-var ROKT_EXTENSIONS = {
-    'Coupon on Signup Extension Detection': 'cos-extension-detection',
-    'Experiment Monitoring': 'experiment-monitoring',
-    'Sponsored Payments Apple Pay': 'sponsored-payments-apple-pay',
-    'Realtime Conversion Promotion': 'realtime-conversion-promotion',
-};
-
 var constructor = function () {
     var self = this;
 
@@ -411,11 +404,7 @@ function extractRoktExtensions(settingsString) {
 
     var roktExtensions = [];
     for (var i = 0; i < settings.length; i++) {
-        var extensionName = settings[i].value;
-        var mappedExtension = ROKT_EXTENSIONS[extensionName];
-        if (mappedExtension) {
-            roktExtensions.push(mappedExtension);
-        }
+        roktExtensions.push(settings[i].value);
     }
 
     return roktExtensions;

test/src/tests.js

@@ -1209,37 +1209,39 @@ describe('Rokt Forwarder', () => {
 
         it('should return base URL when no extensions are provided', () => {
             const url =
-                window.mParticle.forwarder.testHelpers.generateLauncherScript(
-                    []
-                );
+                window.mParticle.forwarder.testHelpers.generateLauncherScript();
             url.should.equal(baseUrl);
         });
 
         it('should return base URL when extensions is null or undefined', () => {
             window.mParticle.forwarder.testHelpers
-                .generateLauncherScript(null)
+                .generateLauncherScript(undefined, null)
                 .should.equal(baseUrl);
 
             window.mParticle.forwarder.testHelpers
-                .generateLauncherScript(undefined)
+                .generateLauncherScript(undefined, undefined)
                 .should.equal(baseUrl);
         });
 
         it('should correctly append a single extension', () => {
             const url =
-                window.mParticle.forwarder.testHelpers.generateLauncherScript([
-                    'cos-extension-detection',
-                ]);
+                window.mParticle.forwarder.testHelpers.generateLauncherScript(
+                    undefined,
+                    ['cos-extension-detection']
+                );
             url.should.equal(baseUrl + '?extensions=cos-extension-detection');
         });
 
         it('should correctly append multiple extensions', () => {
             const url =
-                window.mParticle.forwarder.testHelpers.generateLauncherScript([
-                    'cos-extension-detection',
-                    'experiment-monitoring',
-                    'sponsored-payments-apple-pay',
-                ]);
+                window.mParticle.forwarder.testHelpers.generateLauncherScript(
+                    undefined,
+                    [
+                        'cos-extension-detection',
+                        'experiment-monitoring',
+                        'sponsored-payments-apple-pay',
+                    ]
+                );
             url.should.equal(
                 baseUrl +
                     '?extensions=cos-extension-detection,' +
@@ -1250,40 +1252,31 @@ describe('Rokt Forwarder', () => {
     });
 
     describe('#roktExtensions', () => {
-        beforeEach(() => {
+        beforeEach(async () => {
             window.Rokt = new MockRoktForwarder();
             window.mParticle.Rokt = window.Rokt;
+
+            await window.mParticle.forwarder.init(
+                {
+                    accountId: '123456',
+                },
+                reportService.cb,
+                true
+            );
         });
 
         describe('extractRoktExtensions', () => {
             it('should correctly map known extension names to their query parameters', async () => {
-                window.mParticle.forwarder.testHelpers
-                    .extractRoktExtensions(
-                        '[{"value":"Coupon on Signup Extension Detection"},' +
-                            '{"value":"Experiment Monitoring"},' +
-                            '{"value":"Sponsored Payments Apple Pay"},' +
-                            '{"value":"Realtime Conversion Promotion"}]'
-                    )
-                    .should.deepEqual([
-                        'cos-extension-detection',
-                        'experiment-monitoring',
-                        'sponsored-payments-apple-pay',
-                        'realtime-conversion-promotion',
-                    ]);
-            });
+                const settingsString =
+                    '[{"jsmap":null,"map":null,"maptype":"StaticList","value":"cos-extension-detection"},{"jsmap":null,"map":null,"maptype":"StaticList","value":"experiment-monitoring"}]';
+                const expectedExtensions = [
+                    'cos-extension-detection',
+                    'experiment-monitoring',
+                ];
 
-            it('should ignore unknown or invalid extensions', async () => {
                 window.mParticle.forwarder.testHelpers
-                    .extractRoktExtensions(
-                        '[{"value":"Unknown Extension"},' +
-                            '{"value":"Experiment Monitoring"},' +
-                            '{"invalid_key":"Invalid Format"},' +
-                            '{"value":"Sponsored Payments Apple Pay"}]'
-                    )
-                    .should.deepEqual([
-                        'experiment-monitoring',
-                        'sponsored-payments-apple-pay',
-                    ]);
+                    .extractRoktExtensions(settingsString)
+                    .should.deepEqual(expectedExtensions);
             });
         });
     });