Skip to content

fix: Update attachLauncher to use options object for integration settings#29

Merged
alexs-mparticle merged 1 commit into
developmentfrom
fix/SQDSDKS-7288-configuration
May 13, 2025
Merged

fix: Update attachLauncher to use options object for integration settings#29
alexs-mparticle merged 1 commit into
developmentfrom
fix/SQDSDKS-7288-configuration

Conversation

@alexs-mparticle

Copy link
Copy Markdown
Collaborator

Summary

Adds noFunctional and noTargeting to createLauncher options.

Testing Plan

Pass in noFunctional and noTargeting via the config object in a sample app

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the launcher attachment logic to use an options object for integration settings by adding new optional flags "noFunctional" and "noTargeting".

  • Added new properties in the test suite to validate the new options.
  • Updated the launcher initialization in Rokt-Kit.js to merge the new options when attaching the launcher.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/src/tests.js Added tests to verify that "noFunctional" and "noTargeting" are correctly set when provided, and omitted when not included.
src/Rokt-Kit.js Updated attachLauncher to use an options object and propagate the integration name along with the new optional flags.
Comments suppressed due to low confidence (1)

src/Rokt-Kit.js:63

  • [nitpick] Consider renaming this variable to 'customIntegrationName' to clearly differentiate the raw custom flag value from the processed integration name computed by generateIntegrationName.
var integrationName = customFlags && customFlags['Rokt.integrationName'];

@BrandonStalnaker BrandonStalnaker left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to my inexperienced eyes (and Cursors)

@alexs-mparticle alexs-mparticle merged commit a6ad782 into development May 13, 2025
4 checks passed
github-actions Bot pushed a commit that referenced this pull request May 13, 2025
## [1.3.1](v1.3.0...v1.3.1) (2025-05-13)

### Bug Fixes

* Update attachLauncher to use options object for integration settings ([#29](#29)) ([a6ad782](a6ad782))
* Update integrationName to support postfix ([#28](#28)) ([1180363](1180363))
@alexs-mparticle alexs-mparticle deleted the fix/SQDSDKS-7288-configuration branch March 25, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants