Skip to content

feat: Expose Rokt launcher config options #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexs-mparticle merged 8 commits into from
May 30, 2025
Merged

feat: Expose Rokt launcher config options #30

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3272ea4
feat: Expose Rokt launcher config options
alexs-mparticle May 20, 2025
1d207db
Revise launcher options passthrough
alexs-mparticle May 21, 2025
3958b11
Update tests
alexs-mparticle May 21, 2025
098a01c
Address PR Comments
alexs-mparticle May 21, 2025
a283b2e
Update test/src/tests.js
alexs-mparticle May 21, 2025
963f255
Add manager options
alexs-mparticle May 29, 2025
62de5fd
Update tests
alexs-mparticle May 29, 2025
9676307
Clean up code
alexs-mparticle May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions src/Rokt-Kit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ var constructor = function () {
self.filters = {};
self.filteredUser = {};
self.userAttributes = {};
self.launcherOptions = {};
Comment thread
alexs-mparticle marked this conversation as resolved.
Outdated

/**
* Passes attributes to the Rokt Web SDK for client-side hashing
Expand All @@ -51,25 +52,19 @@ var constructor = function () {
testMode,
_trackerId,
filteredUserAttributes,
filteredUserIdentities,
appVersion,
appName,
customFlags
_filteredUserIdentities,
_appVersion,
_appName,
_customFlags
Comment thread
alexs-mparticle marked this conversation as resolved.
Outdated
) {
var accountId = settings.accountId;
self.userAttributes = filteredUserAttributes;
self.onboardingExpProvider = settings.onboardingExpProvider;

var integrationName =
customFlags && customFlags['Rokt.integrationName'];
var noFunctional = customFlags && customFlags['Rokt.noFunctional'];
var noTargeting = customFlags && customFlags['Rokt.noTargeting'];

var launcherOptions = {
integrationName: generateIntegrationName(integrationName),
noFunctional: noFunctional,
noTargeting: noTargeting,
};
var launcherOptions = window.mParticle.Rokt.launcherOptions || {};
launcherOptions.integrationName = generateIntegrationName(
launcherOptions.integrationName
);

if (testMode) {
attachLauncher(accountId, launcherOptions);
Expand Down
25 changes: 15 additions & 10 deletions test/src/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ describe('Rokt Forwarder', () => {

afterEach(() => {
window.mParticle.forwarder.userAttributes = {};
delete window.mParticle.forwarder.launcherOptions;
Comment thread
alexs-mparticle marked this conversation as resolved.
delete window.mParticle.Rokt.launcherOptions;
});

describe('#initForwarder', () => {
Expand Down Expand Up @@ -138,7 +140,13 @@ describe('Rokt Forwarder', () => {
window.Rokt.createLauncherCalled.should.equal(true);
});

it('should set optional settings from customFlags', async () => {
it('should set optional settings from launcherOptions', async () => {
window.mParticle.Rokt.launcherOptions = {
integrationName: 'customName',
noFunctional: true,
noTargeting: true,
};

await mParticle.forwarder.init(
{
accountId: '123456',
Expand All @@ -149,12 +157,7 @@ describe('Rokt Forwarder', () => {
{},
null,
null,
null,
{
'Rokt.integrationName': 'customName',
'Rokt.noFunctional': true,
'Rokt.noTargeting': true,
}
null
);

var expectedIntegrationName =
Expand Down Expand Up @@ -244,7 +247,7 @@ describe('Rokt Forwarder', () => {
);
});

it('should append custom integration name to integrationName if customFlags is passed', async () => {
it('should append custom integration name to integrationName if passed in launcherOptions', async () => {
const packageVersion = require('../../package.json').version;
const customIntegrationName = 'myCustomIntegration';

Expand All @@ -255,6 +258,9 @@ describe('Rokt Forwarder', () => {
window.mParticle.Rokt.attachKitCalled = true;
return Promise.resolve();
};
window.mParticle.Rokt.launcherOptions = {
integrationName: customIntegrationName,
};

// Simulate the forwarder appending the custom integration name
window.Rokt.integrationName =
Expand All @@ -273,8 +279,7 @@ describe('Rokt Forwarder', () => {
{},
null,
null,
null,
{ 'Rokt.integrationName': customIntegrationName }
null
);

window.Rokt.integrationName.should.equal(
Expand Down