fix: return the select placements call#31
Merged
Conversation
alexs-mparticle
approved these changes
May 23, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
May 27, 2025
## [1.3.2](v1.3.1...v1.3.2) (2025-05-27) ### Bug Fixes * return the select placements call ([#31](#31)) ([38b4903](38b4903))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We need to return the select placements call so that the await-ed promise can be used by the partner. Currently a select placement call will result in ad placements popping up, but there is no returned object for a partner to call additional methods on.
Testing Plan
Manuslly tested E2E and screenshared w @alexs-mparticle to show
.on(event).subscribeworking.