fix: Revise sandbox setting#32
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how the sandbox flag is applied in the Rokt Web kit by moving it from managerOptions into launcherOptions.
- Moved sandbox setting out of
managerOptionsand intolauncherOptions - Updated
attachLaunchersignature and merge logic to use onlylauncherOptions - Updated unit tests to reference
launcherOptionsinstead ofmanagerOptions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/src/tests.js | Updated tests to use launcherOptions in place of managerOptions |
| src/Rokt-Kit.js | Removed managerOptions handling, adjusted attachLauncher accordingly |
Comments suppressed due to low confidence (1)
test/src/tests.js:144
- [nitpick] Add a test case to verify that when
launcherOptions.sandboxis omitted, the SDK still defaults to sandbox=false to guard against regressions in default behavior.
it('should set sandbox to true if sandbox is true in launcherOptions', async () => {
rmi22186
approved these changes
Jun 3, 2025
alexs-mparticle
added a commit
that referenced
this pull request
Jun 3, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
## [1.4.1](v1.4.0...v1.4.1) (2025-06-03) ### Bug Fixes * Revise sandbox setting ([#32](#32)) ([f79830b](f79830b))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan