Skip to content

fix: Prevent mutation of global launcherOptions during initialization #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexs-mparticle merged 2 commits into from
Jul 9, 2025
Merged

fix: Prevent mutation of global launcherOptions during initialization #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f4e64b
fix: Prevent mutation of global launcherOptions during initialization
alexs-mparticle Jul 1, 2025
3bef37e
refactor: Update integration name formatting to use template literals…
alexs-mparticle Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Rokt-Kit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ var constructor = function () {
self.userAttributes = filteredUserAttributes;
self.onboardingExpProvider = settings.onboardingExpProvider;
var domain = window.mParticle.Rokt.domain;
var launcherOptions = window.mParticle.Rokt.launcherOptions || {};
var launcherOptions = mergeObjects(
Comment thread
alexs-mparticle marked this conversation as resolved.
{},
window.mParticle.Rokt.launcherOptions || {}
);
launcherOptions.integrationName = generateIntegrationName(
launcherOptions.integrationName
);
Expand Down
43 changes: 22 additions & 21 deletions test/src/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
/* eslint-env es6, mocha */
/* eslint-parser babel-eslint */

const packageVersion = require('../../package.json').version;
const sdkVersion = 'mParticle_wsdkv_1.2.3';
const kitVersion = 'kitv_' + packageVersion;

const waitForCondition = async (conditionFn, timeout = 200, interval = 10) => {
return new Promise((resolve, reject) => {
const startTime = Date.now();
Expand Down Expand Up @@ -195,10 +199,7 @@ describe('Rokt Forwarder', () => {
null
);

var expectedIntegrationName =
'mParticle_wsdkv_1.2.3_kitv_' +
require('../../package.json').version +
'_customName';
const expectedIntegrationName = `${sdkVersion}_${kitVersion}_customName`;

window.Rokt.createLauncherCalled.should.equal(true);
window.Rokt.accountId.should.equal('123456');
Expand Down Expand Up @@ -241,7 +242,6 @@ describe('Rokt Forwarder', () => {
});

it('should set integrationName in the correct format', async () => {
const packageVersion = require('../../package.json').version;
window.Rokt = new MockRoktForwarder();
window.mParticle.Rokt = window.Rokt;
window.mParticle.Rokt.attachKitCalled = false;
Expand All @@ -259,13 +259,12 @@ describe('Rokt Forwarder', () => {
);

window.Rokt.integrationName.should.equal(
'mParticle_wsdkv_1.2.3_kitv_' + packageVersion
`${sdkVersion}_${kitVersion}`
);
});

it('should append custom integration name to integrationName if passed in launcherOptions', async () => {
const packageVersion = require('../../package.json').version;
const customIntegrationName = 'myCustomIntegration';
it('should not mutate the global launcherOptions object during initialization', async () => {
const originalIntegrationName = 'globalIntegrationName';

window.Rokt = new MockRoktForwarder();
window.mParticle.Rokt = window.Rokt;
Expand All @@ -274,16 +273,16 @@ describe('Rokt Forwarder', () => {
window.mParticle.Rokt.attachKitCalled = true;
return Promise.resolve();
};

// Set up the global launcherOptions with a custom integration name
window.mParticle.Rokt.launcherOptions = {
integrationName: customIntegrationName,
integrationName: originalIntegrationName,
sandbox: true,
};

// Simulate the forwarder appending the custom integration name
window.Rokt.integrationName =
'mParticle_wsdkv_1.2.3_kitv_' +
packageVersion +
'_' +
customIntegrationName;
// Store reference to verify it doesn't get mutated
const originalLauncherOptions =
window.mParticle.Rokt.launcherOptions;

await mParticle.forwarder.init(
{
Expand All @@ -298,12 +297,14 @@ describe('Rokt Forwarder', () => {
null
);

window.Rokt.integrationName.should.equal(
'mParticle_wsdkv_1.2.3_kitv_' +
packageVersion +
'_' +
customIntegrationName
originalLauncherOptions.integrationName.should.equal(
'globalIntegrationName'
);
originalLauncherOptions.sandbox.should.equal(true);

// Verify the kit still gets the processed integration name
const expectedProcessedName = `${sdkVersion}_${kitVersion}_${originalIntegrationName}`;
window.Rokt.integrationName.should.equal(expectedProcessedName);
});
});

Expand Down