Skip to content

fix: Handle invalid Extension Settings #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexs-mparticle merged 2 commits into from
Jul 14, 2025
Merged

fix: Handle invalid Extension Settings #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a87c1e
fix: Handle invalid Extension Settings
alexs-mparticle Jul 14, 2025
eba7dea
Address PR Comments
alexs-mparticle Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Rokt-Kit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,14 +398,15 @@ function parseSettingsString(settingsString) {
try {
Comment thread
alexs-mparticle marked this conversation as resolved.
return JSON.parse(settingsString.replace(/"/g, '"'));
} catch (error) {
throw new Error('Settings string contains invalid JSON');
console.error('Settings string contains invalid JSON');

Copilot AI Jul 14, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider including the original error object when logging JSON parse failures to provide more context, e.g., console.error('Settings string contains invalid JSON', error);.

Suggested change
console.error('Settings string contains invalid JSON');
console.error('Settings string contains invalid JSON', error);

Copilot uses AI. Check for mistakes.
}
return [];
}

function extractRoktExtensions(settingsString) {
var settings = settingsString ? parseSettingsString(settingsString) : [];

var roktExtensions = [];

for (var i = 0; i < settings.length; i++) {
Comment thread
alexs-mparticle marked this conversation as resolved.
roktExtensions.push(settings[i].value);
}
Expand Down
14 changes: 14 additions & 0 deletions test/src/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,5 +1280,19 @@ describe('Rokt Forwarder', () => {
.should.deepEqual(expectedExtensions);
});
});

it('should handle invalid setting strings', () => {
window.mParticle.forwarder.testHelpers
.extractRoktExtensions('NONE')
.should.deepEqual([]);

window.mParticle.forwarder.testHelpers
.extractRoktExtensions(undefined)
.should.deepEqual([]);

window.mParticle.forwarder.testHelpers
.extractRoktExtensions(null)
.should.deepEqual([]);
});
});
});