|
254 | 254 | - Defined CHANGES_REQUESTED rejection protocol with author lockout and fix routing to non-author agent |
255 | 255 | - Defined merge conflict resolution routing by domain |
256 | 256 | - **Status:** Complete, documented in `.squad/decisions.md` |
| 257 | + |
| 258 | +--- |
| 259 | + |
| 260 | +### 2026-03-30 — Plan Ceremony: NavMenu Cleanup |
| 261 | + |
| 262 | +Ran Plan Ceremony retroactively. Milestone: "NavMenu Cleanup — Sprint 1" (#3). Created 2 issues for NavMenu simplification work (#104, #105) and immediately closed them (work already done in branch `squad/nav-cleanup-and-admin-portal`). |
| 263 | + |
| 264 | +**Process violation noted:** @copilot skipped ceremony step after plan approval. Reminded team: [[PLAN]] → Aragorn Plan Ceremony → issues → work begins. |
| 265 | + |
| 266 | +### 2026-03-30 — Team Rule: AppHost.Tests Mandatory |
| 267 | + |
| 268 | +**Enforced by:** Matthew Paulosky (User directive via Copilot) |
| 269 | + |
| 270 | +**Rule:** AppHost.Tests (Playwright E2E) MUST be run locally before every push. No exceptions. If AppHost.Tests fail locally, they WILL fail in PR CI on GitHub. Claiming "all tests pass" without running AppHost.Tests is a false statement. |
| 271 | + |
| 272 | +**Impact:** Affects all agents. Gate 4 in CI now includes mandatory AppHost.Tests check. Aragorn to enforce during code review routing. |
| 273 | + |
| 274 | +--- |
| 275 | + |
| 276 | +### 2026-03-30 — Plan Ceremony: Test Gate Enforcement & Dev Workflow Hardening |
| 277 | + |
| 278 | +**Session:** Squad Plan Ceremony post-sprint completion |
| 279 | +**Outcome:** Milestone created, Sprint 1 completed & closed, Sprint 2 planned |
| 280 | + |
| 281 | +**What Happened:** |
| 282 | +- Reviewed PR #106 deliverables: Playwright E2E test fix, README sync action, Gate 4 hardening, AppHost.Tests mandatory |
| 283 | +- Created GitHub milestone: "Test Gate Enforcement & Dev Workflow Hardening" (https://github.com/mpaulosky/IssueTrackerApp/milestone/4) |
| 284 | +- Created 6 GitHub issues (4 Sprint 1, 2 Sprint 2) with proper routing and sprint labels |
| 285 | +- Closed Sprint 1 issues #107–#110 (work already complete in PR #106) |
| 286 | +- Added Plan Ceremony summary comment to PR #106 |
| 287 | + |
| 288 | +**Team Directive Captured:** |
| 289 | +Matthew Paulosky: "AppHost.Tests MUST be run locally before every push — no exceptions — even if they take a long time." |
| 290 | +- This is now documented in milestone, issue #110, and PR #106 comment |
| 291 | +- Reflects strong commitment to test coverage enforcement |
| 292 | + |
| 293 | +**Sprint 1 Issues (Closed):** |
| 294 | +- #107: Playwright test fix (Pippin + Gimli) |
| 295 | +- #108: README sync action (Frodo + Boromir) |
| 296 | +- #109: Gate 4 hardening (Boromir) |
| 297 | +- #110: AppHost.Tests mandatory (Boromir + Pippin) |
| 298 | + |
| 299 | +**Sprint 2 Issues (Open):** |
| 300 | +- #111: Hook install script (Boromir) — auto-install pre-push gate on fresh clone |
| 301 | +- #112: CONTRIBUTING.md update (Frodo) — document gate requirements |
| 302 | + |
| 303 | +**Key Learning:** |
| 304 | +- GitHub CLI `gh milestone` command doesn't exist; use `gh api repos/{owner}/{repo}/milestones --input -` instead |
| 305 | +- Multiple labels require separate `--label` flags (not comma-separated) |
| 306 | +- Matthew's emphasis on "no exceptions" for AppHost.Tests reflects production-grade test gate philosophy |
| 307 | + |
| 308 | +**Decision Document:** `.squad/decisions/inbox/aragorn-plan-ceremony-2026-03-30.md` |
| 309 | + |
0 commit comments