Skip to content

[WIP] Refactor subject management and add ICS export features#58

Open
konnn04 wants to merge 2 commits into
mpc-ou:mainfrom
konnn04:dev/260701
Open

[WIP] Refactor subject management and add ICS export features#58
konnn04 wants to merge 2 commits into
mpc-ou:mainfrom
konnn04:dev/260701

Conversation

@konnn04

@konnn04 konnn04 commented Jul 4, 2026

Copy link
Copy Markdown
Member

Description

Modularize the GPA improvement suggestion system with manual links between old and new subjects. Add reminders for ICS export and fix the issue with "Exempt" subjects.

New features:

  • Add manual links for improved subjects using improvesSubjectId and a UUID for each subject.
  • Add new components: GPALadder, ImprovementDetailsDialog, SubjectDialog, LinkImprovementDialog, ProgressTimeline, and UserIdentityDialog.
  • Improve ICS export by adding VALARM reminders, following RFC 5545 line folding, and allowing a custom calendar name.

Bug fixes:

  • Ignore "Exempt" subjects (character M) when calculating GPA.
  • Use effectiveStudentId instead of studentId in saveData to support account switching.
  • Round the GPA before checking the academic ranking table.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Performance improvement
  • Documentation

Checklist

  • Tested on Chrome (pnpm dev)
  • Tested on Firefox (pnpm dev:firefox)
  • pnpm ultracite:check passed
  • pnpm compile passed
  • Commits follow the Conventional Commits format

Ref

#57 #56

@konnn04 konnn04 requested a review from holedev July 4, 2026 13:13
@konnn04 konnn04 self-assigned this Jul 4, 2026
@konnn04 konnn04 added the enhancement New feature or request label Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant