[WIP] Refactor subject management and add ICS export features#58
Open
konnn04 wants to merge 2 commits into
Open
[WIP] Refactor subject management and add ICS export features#58konnn04 wants to merge 2 commits into
konnn04 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modularize the GPA improvement suggestion system with manual links between old and new subjects. Add reminders for ICS export and fix the issue with "Exempt" subjects.
New features:
improvesSubjectIdand a UUID for each subject.GPALadder,ImprovementDetailsDialog,SubjectDialog,LinkImprovementDialog,ProgressTimeline, andUserIdentityDialog.VALARMreminders, following RFC 5545 line folding, and allowing a custom calendar name.Bug fixes:
character M) when calculating GPA.effectiveStudentIdinstead ofstudentIdinsaveDatato support account switching.Type of change
Checklist
pnpm dev)pnpm dev:firefox)pnpm ultracite:checkpassedpnpm compilepassedRef
#57 #56