MFT: adding todos

Author: mpuccio

Detectors/ITSMFT/ITS/tracking/include/ITStracking/Configuration.h

@@ -56,10 +56,10 @@ struct TrackingParameters {
   std::vector<float> LayerRadii = {2.33959f, 3.14076f, 3.91924f, 19.6213f, 24.5597f, 34.388f, 39.3329f};
   std::vector<float> LayerxX0 = {5.e-3f, 5.e-3f, 5.e-3f, 1.e-2f, 1.e-2f, 1.e-2f, 1.e-2f};
   std::vector<float> LayerResolution = {5.e-4f, 5.e-4f, 5.e-4f, 5.e-4f, 5.e-4f, 5.e-4f, 5.e-4f};
-  std::vector<float> SystErrorY2 = {0.f, 0.f, 0.f, 0.f, 0.f, 0.f, 0.f};
-  std::vector<float> SystErrorZ2 = {0.f, 0.f, 0.f, 0.f, 0.f, 0.f, 0.f};
-  int ZBins{256};
-  int PhiBins{128};
+  std::vector<float> SystErrorY2 = {0.f, 0.f, 0.f, 0.f, 0.f, 0.f, 0.f}; ///TODOMFT: generalise the naming to say local systematic row
+  std::vector<float> SystErrorZ2 = {0.f, 0.f, 0.f, 0.f, 0.f, 0.f, 0.f}; ///TODOMFT: generalise the naming to say local systematic col
+  int ZBins{256};  ///TODOMFT: rename to col
+  int PhiBins{128}; ///TODOMFT: renmame to rows
   bool UseDiamond = false;
   float Diamond[3] = {0.f, 0.f, 0.f};
   float DiamondCov[6] = {25.e-6f, 0.f, 0.f, 25.e-6f, 0.f, 36.f};

Detectors/ITSMFT/ITS/tracking/include/ITStracking/IndexTableUtils.h

@@ -28,7 +28,7 @@ namespace o2::its
 {
 
 template <int nLayers>
-class IndexTableUtils
+class IndexTableUtils ///TODOMFT: make name generic phi becomes row and z becomes col
 {
  public:
   template <class T>
@@ -57,7 +57,7 @@ class IndexTableUtils
 template <int nLayers>
 template <class T>
 inline void IndexTableUtils<nLayers>::setTrackingParameters(const T& params)
-{
+{ ///TODOMFT: make this generic to be used for both ITS and MFT without needing to use specific params (input number of columns, rows, and their respective width)
   mInversePhiBinSize = params.PhiBins / o2::constants::math::TwoPI;
   mNzBins = params.ZBins;
   mNphiBins = params.PhiBins;
@@ -115,7 +115,7 @@ GPUhdi() void IndexTableUtils<nLayers>::print() const
 template <int nLayers>
 GPUhdi() int4 getBinsRect(const Cluster& currentCluster, const int layerIndex,
                           const float z1, const float z2, const float maxdeltaz, const float maxdeltaphi,
-                          const IndexTableUtils<nLayers>& utils)
+                          const IndexTableUtils<nLayers>& utils) ///TODOMFT: rename this to getBinsPhiZ, and create a getBinsXY for the MFT case
 {
   const float zRangeMin = o2::gpu::GPUCommonMath::Min(z1, z2) - maxdeltaz;
   const float phiRangeMin = (maxdeltaphi > o2::constants::math::PI) ? 0.f : currentCluster.phi - maxdeltaphi;