subprocess-posix: MP_NO_ASAN

Author: ruihe774

osdep/compiler.h

@@ -9,12 +9,14 @@
 #define MP_NORETURN __attribute__((noreturn))
 #define MP_FALLTHROUGH __attribute__((fallthrough))
 #define MP_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
+#define MP_NO_ASAN __attribute__((no_sanitize("address")))
 #else
 #define PRINTF_ATTRIBUTE(a1, a2)
 #define SCANF_ATTRIBUTE(a1, a2)
 #define MP_NORETURN
 #define MP_FALLTHROUGH do {} while (0)
 #define MP_WARN_UNUSED_RESULT
+#define MP_NO_ASAN
 #endif
 
 // Broken crap with __USE_MINGW_ANSI_STDIO

osdep/subprocess-posix.c

@@ -79,6 +79,7 @@ static int as_execvpe(const char *path, const char *file, char *const argv[],
 static void reset_signals_child(void)
 {
 #if !HAVE_RFORK
+    // RFSPAWN has reset all signal actions in the child to default already
     struct sigaction sa = { 0 };
     sigset_t sigmask;
     sa.sa_handler = SIG_DFL;
@@ -104,10 +105,9 @@ static pid_t spawn_process_inner(const char *path, struct mp_subprocess_opts *op
                                  int src_fds[], bool detach, void *stacks[]);
 
 // This function is called from a clone(CLONE_VM)/rfork_thread context where
-// the child shares the parent's address space. Use no_sanitize to avoid false
+// the child shares the parent's address space. Use MP_NO_ASAN to avoid false
 // positives from ASan when the child writes to shared memory.
-__attribute__((no_sanitize("address")))
-static int child_main(void* args)
+MP_NO_ASAN static int child_main(void* args)
 {
     struct child_args *child_args = args;
     const char *path = child_args->path;
@@ -124,7 +124,6 @@ static int child_main(void* args)
         return 0;
     }
 
-    // RFSPAWN has reset all signal actions in the child to default
     reset_signals_child();
 
     for (int n = 0; n < opts->num_fds; n++) {