ao_pulse: fix subscribe_cb using wrong bitmask for event type#17864
Merged
kasper93 merged 1 commit intompv-player:masterfrom May 3, 2026
Merged
ao_pulse: fix subscribe_cb using wrong bitmask for event type#17864kasper93 merged 1 commit intompv-player:masterfrom
kasper93 merged 1 commit intompv-player:masterfrom
Conversation
PA_SUBSCRIPTION_MASK_SINK is a pa_subscription_mask constant used when registering with pa_context_subscribe(), not a pa_subscription_event_type mask. Masking the event type with it would never match PA_SUBSCRIPTION_EVENT_NEW or PA_SUBSCRIPTION_EVENT_REMOVE, causing hotplug events to be silently dropped. Fixes: e017500
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PA_SUBSCRIPTION_MASK_SINK is a pa_subscription_mask constant used when registering with pa_context_subscribe(), not a
pa_subscription_event_type mask. Masking the event type with it would never match PA_SUBSCRIPTION_EVENT_NEW or PA_SUBSCRIPTION_EVENT_REMOVE, causing hotplug events to be silently dropped.
Fixes: e017500