osxbundle: fix vulkan loader and search paths#18226
Open
Akemi wants to merge 2 commits into
Open
Conversation
the paths in the array are meant to be base paths to the vulkan path. remove vulkan from it so it won't end up as /usr/share/vulkan/vulkan.
the old check stopped at the first occurrence of a vulkan loader path. though it's possible different vulkan loaders are installed in different paths, leading to not found vulkan loaders. to prevent this, also check if the needed vulkan loader is actually installed to that path. specific case is when installing MoltenVK and KosmicKrisp at the same time. the former is installed in the homebrew prefix under etc/ the latter under share/. the latter wasn't found previous, since the former was found first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only the (KosmicKrisp) bundling fixes from #17575, without the actual bundling of KosmicKrisp.