Skip to content

test/libmpv_lifetime: set ao and vo to null#18230

Closed
llyyr wants to merge 1 commit into
mpv-player:masterfrom
llyyr:fix/freebsd-ci
Closed

test/libmpv_lifetime: set ao and vo to null#18230
llyyr wants to merge 1 commit into
mpv-player:masterfrom
llyyr:fix/freebsd-ci

Conversation

@llyyr

@llyyr llyyr commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

This isn't relevant to the test, and saves time spent probing VOs and AOs. In my case, this brings down the test from 3.64s to 1.42s. Hopefully this is enough to make the test not timeout on freebsd.

Read this before you submit this pull request:
https://github.com/mpv-player/mpv/blob/master/DOCS/contribute.md

Reading this link and following the rules will get your pull request reviewed
and merged faster. Nobody wants lazy pull requests.

@kasper93

kasper93 commented Jul 6, 2026

Copy link
Copy Markdown
Member

This isn't relevant to the test, and saves time spent probing VOs and AOs.

It's actually quite relevant. We test if we can open/close vo without crashing and even without display it sets that probing passes cleanly. Removing this makes this test less interesting overall.

One could argue that over 30s of probing is already a bug exposed by this test, and vo=null only hides the root cause.

We can bump timeout if this is expected to take this much or more time.

@llyyr

llyyr commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

We can bump timeout if this is expected to take this much or more time.

I don't think it's expected that it takes this long, this test takes 3.5s even without setting vo=null on linux. It's only freebsd that's a problem, and not a mpv regression. Someone who uses freebsd would need to figure out the problem instead.

I can switch to just raising the timeout though

@llyyr llyyr force-pushed the fix/freebsd-ci branch 6 times, most recently from 330ef95 to b474c10 Compare July 6, 2026 02:53
@llyyr llyyr force-pushed the fix/freebsd-ci branch from b474c10 to fe0194e Compare July 6, 2026 03:06
@llyyr

llyyr commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Closing because increasing the timeout doesn't fix it. The final talloc_free(mpctx) in mp_destroy stalls indefinitely on FreeBSD after July 2nd, but only on the second mpv_handle. Setting vo=null fixes that but i don't know why, maybe some VO has child that stalls indefinitely when freeing from failed state but I don't know why it would only happen on freebsd either

@llyyr llyyr closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants