Skip to content

Commit 17077cd

Browse files
chore(ci): add missing container-tag/container-suffix and fix stale standards doc (#309)
* chore(ci): add missing container-tag/container-suffix and fix stale standards doc Add container-tag and container-suffix parameters to all reusable workflow jobs (audit, quality, security, test, version) in ci.yml. Fix repository-standards.md: correct git hooks path, rename st-submit-pr to vrg-submit-pr, replace markdownlint requirement with vrg-docker-run, remove stale --agent and --docs-only flags, fix --linkage default from Fixes to Ref. Addresses vergil-project/vergil-tooling#1015, vergil-project/vergil-tooling#1013 Co-Authored-By: Claude <noreply@anthropic.com> * fix(ci): use base container suffix for common CI jobs * fix(ci): revert container params and add VERSION file Remove container-suffix/container-tag from ci.yml — workflow defaults are correct for Java repos. Add canonical VERSION file (1.2.2) for vrg-version. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(ci): add container-suffix to audit and test jobs The ci-audit and ci-test reusable workflows default container-suffix to base, which produces prod-base:<version> — an image that does not exist. Set container-suffix: java so these jobs use prod-java:<version>. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent 628508a commit 17077cd

3 files changed

Lines changed: 9 additions & 8 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ jobs:
3737
with:
3838
language: java
3939
versions: ${{ inputs.java-versions || '["17", "21"]' }}
40+
container-suffix: java
4041

4142
integration-tests:
4243
name: "test / integration / ${{ matrix.java-version }}"
@@ -103,6 +104,7 @@ jobs:
103104
with:
104105
language: java
105106
versions: ${{ inputs.java-versions || '["17", "21"]' }}
107+
container-suffix: java
106108

107109
version:
108110
uses: vergil-project/vergil-actions/.github/workflows/ci-version-bump.yml@v2.0

VERSION

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
1.2.2

docs/repository-standards.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
- Before modifying any files, check the current branch with `git status -sb`.
1515
- If on `develop`, create a short-lived `feature/*` branch or ask for explicit approval to proceed on `develop`.
1616
- If approval is granted to work on `develop`, call it out in the response and proceed only for that user-approved scope.
17-
- Enable repository git hooks before committing: `git config core.hooksPath scripts/git-hooks`.
17+
- Enable repository git hooks before committing: `git config core.hooksPath .githooks`.
1818

1919
## Local validation
2020

@@ -46,7 +46,7 @@ Required for daily workflow:
4646

4747
- Java 17+ (`brew install openjdk@17` or SDKMAN)
4848
- Maven Wrapper (`./mvnw`, checked into repo -- no separate Maven install needed)
49-
- `markdownlint` (required for docs validation and PR pre-submission)
49+
- `vrg-docker-run` (runs validation inside dev container)
5050

5151
## Merge strategy override
5252

@@ -66,14 +66,13 @@ submission. Do not construct commit messages or PR bodies manually.
6666

6767
```bash
6868
vrg-commit \
69-
--type TYPE --message MESSAGE --agent AGENT \
69+
--type TYPE --message MESSAGE \
7070
[--scope SCOPE] [--body BODY]
7171
```
7272

7373
- `--type` (required): one of
7474
`feat|fix|docs|style|refactor|test|chore|ci|build`
7575
- `--message` (required): commit description
76-
- `--agent` (required): `claude` or `codex`
7776
- `--scope` (optional): conventional commit scope
7877
- `--body` (optional): detailed commit body
7978

@@ -83,20 +82,19 @@ The script resolves the correct `Co-Authored-By` identity from
8382
### Submitting PRs
8483

8584
```bash
86-
st-submit-pr \
85+
vrg-submit-pr \
8786
--issue NUMBER --summary TEXT \
8887
[--linkage KEYWORD] [--title TEXT] \
89-
[--notes TEXT] [--docs-only] [--dry-run]
88+
[--notes TEXT] [--dry-run]
9089
```
9190

9291
- `--issue` (required): GitHub issue number (just the number)
9392
- `--summary` (required): one-line PR summary
94-
- `--linkage` (optional, default: `Fixes`):
93+
- `--linkage` (optional, default: `Ref`):
9594
`Fixes|Closes|Resolves|Ref`
9695
- `--title` (optional): PR title (default: most recent commit
9796
subject)
9897
- `--notes` (optional): additional notes
99-
- `--docs-only` (optional): applies docs-only testing exception
10098
- `--dry-run` (optional): print generated PR without executing
10199

102100
The script detects the target branch and merge strategy

0 commit comments

Comments
 (0)