Skip to content

Commit 764f3dc

Browse files
committed
moved the calls back
I moved the calls for lidHookOutside(); buildLightTubes(); buildButtons(); lidHookInside(); back to the original locations. This fixed the button issue (and I'm assuming the inside/outside issues). I don't have any code for the inside/outside modules to test with. But it does break (well maybe not break but change) the inspectx/y functionality. But I do see that you had separate inspect options for the light tubes and buttons so having them as part of the inspect function wasn't there before. If I get a chance I may look at how to get the inspectx/y working for everything but as you have the other options it's probably not necessary.
1 parent 5b1fddd commit 764f3dc

1 file changed

Lines changed: 7 additions & 15 deletions

File tree

library/YAPPgenerator_v21.scad

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2745,12 +2745,6 @@ module lidShell()
27452745

27462746
pcbPushdowns();
27472747
shellConnectors("lid");
2748-
2749-
// Moved to lidShell so they can be cut for inspection
2750-
lidHookOutside();
2751-
buildLightTubes(); //-2.0-
2752-
buildButtons(); //-2.0-
2753-
lidHookInside();
27542748

27552749
} // lidShell()
27562750

@@ -3265,10 +3259,9 @@ module YAPPgenerate()
32653259
{
32663260
translate([0, (5 + shellWidth+(shiftLid/2))*-2, 0])
32673261
{
3268-
// Moved inside lidShell() so they can be cut by the inspection planes
3269-
//buildLightTubes(); //-2.0-
3270-
//buildButtons(); //-2.0-
3271-
//lidHookInside();
3262+
buildLightTubes(); //-2.0-
3263+
buildButtons(); //-2.0-
3264+
lidHookInside();
32723265

32733266
difference() // (t1)
32743267
{
@@ -3352,11 +3345,10 @@ module YAPPgenerate()
33523345
translate([0, 0, (baseWallHeight+basePlaneThickness+
33533346
lidWallHeight+lidPlaneThickness+onLidGap)])
33543347
{
3355-
// Moved inside lidShell() so they can be cut by the inspection planes
3356-
//lidHookOutside();
3357-
//buildLightTubes(); //-2.0-
3358-
//buildButtons(); //-2.0-
3359-
//lidHookInside();
3348+
lidHookOutside();
3349+
buildLightTubes(); //-2.0-
3350+
buildButtons(); //-2.0-
3351+
lidHookInside();
33603352

33613353
difference() // (t2)
33623354
{

0 commit comments

Comments
 (0)