Skip to content

Commit 71d357a

Browse files
Kai-Heng Fenggregkh
authored andcommitted
igb: Fix an issue that PME is not enabled during runtime suspend
[ Upstream commit 1fb3a7a75e2efcc83ef21f2434069cddd6fae6f5 ] I210 ethernet card doesn't wakeup when a cable gets plugged. It's because its PME is not set. Since commit 42eca23 ("PCI: Don't touch card regs after runtime suspend D3"), if the PCI state is saved, pci_pm_runtime_suspend() stops calling pci_finish_runtime_suspend(), which enables the PCI PME. To fix the issue, let's not to save PCI states when it's runtime suspend, to let the PCI subsystem enables PME. Fixes: 42eca23 ("PCI: Don't touch card regs after runtime suspend D3") Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 8181b2f commit 71d357a

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

drivers/net/ethernet/intel/igb/igb_main.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7950,9 +7950,11 @@ static int __igb_shutdown(struct pci_dev *pdev, bool *enable_wake,
79507950
rtnl_unlock();
79517951

79527952
#ifdef CONFIG_PM
7953-
retval = pci_save_state(pdev);
7954-
if (retval)
7955-
return retval;
7953+
if (!runtime) {
7954+
retval = pci_save_state(pdev);
7955+
if (retval)
7956+
return retval;
7957+
}
79567958
#endif
79577959

79587960
status = rd32(E1000_STATUS);

0 commit comments

Comments
 (0)