new function to preprocess data for meta analysis of proportions#46
Merged
Conversation
Collaborator
Author
|
please review jointly with: mrc-ide/priority-pathogens#31 |
cm401
reviewed
Apr 27, 2024
cm401
reviewed
Apr 27, 2024
Comment on lines
+1
to
+4
| # epireview 1.1.2 | ||
|
|
||
| * Add filter_df_for_metaprop function | ||
|
|
Collaborator
There was a problem hiding this comment.
Same as above, I think this needs to be 1.1.3 as previous PR with 1.1.2 already exists
cm401
reviewed
Apr 27, 2024
Collaborator
cm401
left a comment
cm401
left a comment
There was a problem hiding this comment.
Other than version numbers this looks good.
Can we please what with this PR + the priority pathogens PR until the current issues with the repo and conflicts have been resolved?
sangeetabhatia03
approved these changes
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roughly mirrors the function for meta analysis of means