updating to directly input ACH and infer riskiness. User defined efficacy from delta ACH by cwhittaker1000 · Pull Request #142 · mrc-ide/helios

cwhittaker1000 · 2026-01-22T00:12:02Z

As above; this addresses and answers #136 - @geethaj1 will be handling this.

cwhittaker1000 · 2026-01-22T00:24:45Z

Aim with this PR is get helios into a position where we're directly inputting ACH values (probably specifying a distribution that we draw from) into the run_function, instead of riskiness parameters (specifying a riskiness distribution, itself derived externally from ACH values, see here).

The aim with doing this is to enable us to calculate efficacy not as a single input value, but as a function of ACH in each location; whilst also retaining the ability to specify riskiness, again in a location specific manner.

This is very rough, but based on our convo today, it seems like there are 4 broad pieces of work to be done here (not necessarily in this order):

Change the arguments and inputs of run_simulation (and the associated functions for generating the parameter list) to take in parameters that specify ACH values, rather than riskiness values. For example, these might be the setting-specific mean and sd of a normal distribution (but let's chat more about the exact parameterisation).
Change the arguments and inputs of run_simulation to take in parameters that specify the relationship between ACH and efficacy, conditional on e.g. some max_efficacy (or similar, we can talk about the exact parameterisation).
Use those parameters inside run_simulation (possibly within their own function, which is called within run_simulation) to draw an ACH for each location (e.g. for each location of a setting type, draw from a normal with setting-type specific ACH mean and sd defined in 1))
Use those ACHs for each location to get a corresponding riskiness (probably using the framework we initially developed in
this).
Use those ACHs to also calculate for each location (of each setting type) an intervention efficacy that is calculated based on their ACH and the new parameter inputs specified in 1).

…ose on the riskiness distribution

… riskiness.

geethaj1 · 2026-02-11T21:24:11Z

Updates:

Code to explore normal and lognormal distributions of ACH and impact on riskiness distributions in R/normal_dist_ACH_exploration.R and R/lognormal_ACH_dist.R
Created script r/setting_specific_ACH.R which includes:

function to draw ACH values from truncated normal distribution generate_setting_specific_ach()
function to convert raw ACH to riskiness value convert_ach_to_riskiness(), using the W-R model and parameters
placeholder function to calculating efficacy from ach calculate_efficacy_from_ach() (function not defined yet)
function for user to specify ACH distribution parameters set_setting_specific_ach()

Modified parameters.R

added W_R model parameters (emission rate, decay rate, p_inf, etc)
added setting specific room volumes
added ACH distribution parameters (mean, sd) for each setting type
added efficacy parameters (placeholders, haven't defined function)

Modified variables.R
-replaced riskiness generation with ACH

(placeholder) location specific efficacies based on ACH
I

… for relationship

…r each type of location, etc.)

…etting_specific_ach script

geethaj1 · 2026-02-25T23:29:35Z

Summary of changes:

set_setting_specific_riskiness.R is replaced by set_setting_specific_ach.R where user specifies the parameters of ach truncated normal distributions for each setting type instead of specifying the parameters of riskiness truncated lognormal distributions through user-facing set_setting_specific_ach() function.
ACH values are converted to riskiness using W-R through the convert_ach_to_riskiness()
ACH values are also used to calculate efficacy, where the user can choose from a constant or sigmoid function to define the relationship between ach and efficacy of intervention. The user does this through the set_uvc_ach() function

… estimates

…ific function based on tests

github-actions · 2026-04-09T00:26:07Z

+    #ach to efficacy parameters_workplace
+    far_uvc_workplace_ach_efficacy_relationship = NULL, #constant or sigmoid
+    far_uvc_workplace_efficacy = NULL, #constant
+    far_uvc_workplace_max_efficacy = NULL,  # sigmoid


[air] _{reported by reviewdog 🐶}

Suggested change

far_uvc_workplace_max_efficacy = NULL, # sigmoid

far_uvc_workplace_max_efficacy = NULL, # sigmoid

github-actions · 2026-04-09T00:26:07Z

+    #ach to efficacy parameters_school
+    far_uvc_school_ach_efficacy_relationship = NULL, #constant or sigmoid
+    far_uvc_school_efficacy = NULL, #constant
+    far_uvc_school_max_efficacy = NULL,  # sigmoid


[air] _{reported by reviewdog 🐶}

Suggested change

far_uvc_school_max_efficacy = NULL, # sigmoid

far_uvc_school_max_efficacy = NULL, # sigmoid

github-actions · 2026-04-09T00:26:07Z

+set_uvc_ach <- function (parameters_list,
+                         setting,
+                         coverage,
+                         coverage_target,
+                         coverage_type,
+                         timestep,
+                         relationship_type,
+                         max_efficacy,
+                         sigmoid_k,
+                         sigmoid_x0) {
+


[air] _{reported by reviewdog 🐶}

Suggested change

set_uvc_ach <- function (parameters_list,

setting,

coverage,

coverage_target,

coverage_type,

timestep,

relationship_type,

max_efficacy,

sigmoid_k,

sigmoid_x0) {

set_uvc_ach <- function(

parameters_list,

setting,

coverage,

coverage_target,

coverage_type,

timestep,

relationship_type,

max_efficacy,

sigmoid_k,

sigmoid_x0

) {

github-actions · 2026-04-09T00:26:08Z

+
+

[air] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2026-04-09T00:26:08Z

+    setting = "household"
+  )
+
+


[air] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2026-04-09T00:26:08Z

+  if (any(parameters_list$far_uvc_joint,
+          parameters_list$far_uvc_workplace,
+          parameters_list$far_uvc_school,
+          parameters_list$far_uvc_leisure,
+          parameters_list$far_uvc_household)) {


[air] _{reported by reviewdog 🐶}

Suggested change

if (any(parameters_list$far_uvc_joint,

parameters_list$far_uvc_workplace,

parameters_list$far_uvc_school,

parameters_list$far_uvc_leisure,

parameters_list$far_uvc_household)) {

if (

any(

parameters_list$far_uvc_joint,

parameters_list$far_uvc_workplace,

parameters_list$far_uvc_school,

parameters_list$far_uvc_leisure,

parameters_list$far_uvc_household

)

) {

github-actions · 2026-04-09T00:26:08Z

+      parameters_list[paste0("far_uvc_", setting_types, "_efficacy")] <- parameters_list$far_uvc_joint_efficacy
+      parameters_list[paste0("far_uvc_", setting_types, "_timestep")] <- parameters_list$far_uvc_joint_timestep


[air] _{reported by reviewdog 🐶}

Suggested change

parameters_list[paste0("far_uvc_", setting_types, "_efficacy")] <- parameters_list$far_uvc_joint_efficacy

parameters_list[paste0("far_uvc_", setting_types, "_timestep")] <- parameters_list$far_uvc_joint_timestep

parameters_list[paste0(

"far_uvc_",

setting_types,

"_efficacy"

)] <- parameters_list$far_uvc_joint_efficacy

parameters_list[paste0(

"far_uvc_",

setting_types,

"_timestep"

)] <- parameters_list$far_uvc_joint_timestep

… tests to check that it works

…tions to interventions.R

cwhittaker1000 · 2026-05-19T17:48:56Z

@geethaj1 - quick q as I'm running through the code. Are there any files in inst that directly relate to or inform the code/default parameters in the model? If so, I'm thinking we should make a separate folder in inst called VIP or similar where we keep track of all these scripts. I'm motivated by the fact I keep trying to find that lognormal params script I wrote ages ago in inst whenever we want to look something related to that up. Would be good to have them all in one place - do you have any scripts like that or are they all mainly just for testing the model after you've made changes?

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

cwhittaker1000

Great stuff @geethaj1 - really impressive work here. Everything looks broadly right to me - some minor comments/questions enclosed and I think the big piece is tidying this up and documentation improvements ahead of merge. Congrats!

cwhittaker1000 · 2026-05-19T17:53:24Z

+    volume_per_person_leisure = 8, # 2m^2*4M
+    volume_per_person_household = 50, # 20m^2 * 2.5m
+
+    # W-R parameters


Let's have a conversation about how much we want to expose these parameters - I think doing so is fine but useful to have a conversation about helper functions vs forcing users to input these directly etc.

cwhittaker1000 · 2026-05-19T17:55:41Z

+  #   far_uvc_household_sigmoid_x0 = NULL,
+
+  # Intervention parameters (Wells-Riley ACH-based efficacy):
+    intervention_joint_active              = FALSE,


I don't think any of these parameters are currently documented in the above documentation on inputs or elsewhere? I'm currently having to infer and understand them based on context and reading other parts of the codebase, which is time consuming. Can you make sure all these are documented and described please?

cwhittaker1000 · 2026-05-19T17:57:26Z

+    intervention_household_covered         = NULL,

    # Room Size Per Individual Parameters:
    size_per_individual_workplace = 1,


Do we still need these if we have the volume parameters above?

cwhittaker1000 · 2026-05-19T17:58:31Z

-      )
-    }
-  }
+  # # Old targeted_riskiness validation against the removed far_uvc_* config


Same comment as above - I think you can get rid of this and remove the commented code. If you're unsure whether we might need to return to it, save this version of parameters.R in an inst folder called old_scripts or similar. Remember we have version control so can always go back to this commit to view it either way!

cwhittaker1000 · 2026-05-19T18:31:30Z

+  # calculation runs through the same code path.
+  for (s in c("workplace", "school", "leisure")) {
+    parameters_list[[paste0("intervention_", s, "_active")]]   <- TRUE
+    parameters_list[[paste0("intervention_", s, "_list")]]     <- parameters_list$intervention_joint_list


What is this parameter intervention_joint_list - I can't figure it out and where it's used/what for?

Is the list of things like what it does to modify ACH etc that we discussed?

Yes, intervention_joint_list stores the list of interventions (in this branch its just 1 intervention), and describes the characteristics of the intervention. It's used in calculate_efficacy_from_ach to get information about the interventino, and in generate_joint-intervention_switches for coverage allocation.

cwhittaker1000 · 2026-05-19T18:38:15Z

+                              variation_function       = NULL,
+                              variation_params         = list(),
+                              coverage                 = NULL) {
+  list(


I think we need some checks in here - if affected_by_baseline_ach is set to FALSE, then baseline_ach_function should be NULL right?

Related point is that none of these parameters are documented or particularly clear - I think we need clearer documentation of what they are and what they mean/correspond to.

cwhittaker1000 · 2026-05-19T18:39:12Z

+                                 coverage_target,
+                                 coverage_type,
+                                 timestep,
+                                 ...) {


Instead of having the ... why not just force the user to pass in the list directly?

cwhittaker1000 · 2026-05-19T18:40:10Z

+# Efficacy at location i = 1 - p_post[i] / p_pre[i], where the post-intervention
+# alpha is augmented by the sum of intervention deltas (zeroed for uncovered
+# locations via the coverage vector).
+calculate_efficacy_from_ach <- function(ach_values, parameters_list, setting) {


this is really nice work Geetha!

cwhittaker1000 · 2026-05-19T18:40:55Z

+
+
+# =============================================================================
+# Helper functions for ACH / efficacy / UV-C conversions


haven't looked at the below in detail as presume they're helper functions not used anywhere much. Let me know if that seems wrong

baseline_ach_function -> delta_function baseline_ach_params -> delta_params affected_by_baseline_ach -> delta_depends_on_baseline_ach better represents that they describe the delta the intervention adds (and whether that delta depends on baseline ACH).

making branch appear online

588ab04

geethaj1 added 2 commits February 10, 2026 23:27

exploring normal and lognormal ACH distributions and the effect of th…

299da28

…ose on the riskiness distribution

Implementing replacement of directly inputting riskiness with ACH -->…

691b978

… riskiness.

geethaj1 and others added 4 commits February 11, 2026 14:25

updates to replace efficacy inputs with ach inputs

e031316

moving from /man to /R

bbb5b9a

Update setting_specific_ach.R

65eb2ce

Update setting_specific_ach.R

314bf02

geethaj1 reviewed Feb 12, 2026

View reviewed changes

Comment thread R/parameters.R

geethaj1 added 2 commits February 17, 2026 13:29

setting up ach to efficacy pipeline with constant and sigmoid options…

3bfcb0f

… for relationship

update parameters for ach efficacy

e11ebbc

cwhittaker1000 commented Feb 17, 2026

View reviewed changes

Comment thread R/parameters.R

Comment thread R/setting_specific_ach.R Outdated

Comment thread R/setting_specific_ach.R Outdated

Comment thread R/setting_specific_ach.R Outdated

geethaj1 added 8 commits February 18, 2026 09:12

removing duplicate

3297541

adjusting room volume to be calculated using density * number of people

3590308

continuing to add to ach --> efficacy pipeline

2582144

cleaning up errors in code (forgotten closing brackets, parameters fo…

597b108

…r each type of location, etc.)

added based on claude suggestion

aef96ec

Test run with a signmoid function for workplace efficacy + edits to s…

f714a04

…etting_specific_ach script

removing duplicate calculate_efficacy_from_ach call

fac2c6e

moving test scripts to inst

1b0354a

geethaj1 added 8 commits February 25, 2026 16:50

multiple settings

af4b4b0

updates to room volume based on ASHRAE area densities and room height…

5ca5e03

… estimates

minor edit to constant ach script

0d2d6e6

tests with UVC with new ACH pipeline + adjustment to set_setting_spec…

ebcb680

…ific function based on tests

added riskiness plots per location type

4aa74f0

more tests

bedb90c

moved to inst

91b8e28

gathering metrics from tests

6f3ef3e

geethaj1 added 2 commits April 8, 2026 17:25

updating git ignore

cf09d76

adding run data to avoid re-running large simulations

81a0651

github-actions Bot reviewed Apr 9, 2026

View reviewed changes

geethaj1 added 17 commits April 21, 2026 21:32

update to efficacy to incorporate ach and uv interventions

a445c56

updates

1265c7f

edits to ach --> efficacy

adda564

label edit

3a53783

cleaning up test runs

ca0f0fd

updates

a4711c0

script outline for how to implement agnostic intervention

5f3e663

moving draft to inst and update ach script

1c4980c

update to parameter.R with new params

484e3e8

comment out old code

d58a50c

testing new implementation

bfcb842

edit

23b5956

fixing piping for new intervention implementation

b5e3c25

Moving ach intervention pipeline to interventions.R + run preliminary…

6b3d22a

… tests to check that it works

Commenting out old code, and moving all functions related to interven…

fca4247

…tions to interventions.R

edits from review

621164c

edits based on code review

9c6d950

geethaj1 changed the title ~~updating to directly input ACH and infer riskiness and intervention efficacy from that~~ updating to directly input ACH and infer riskiness. User defined efficacy from delta ACH May 18, 2026

geethaj1 added 2 commits May 18, 2026 12:34

fixing coverage error in code

66fd281

tests

9405742

Apply suggestion from @github-actions[bot]

1adce15

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

cwhittaker1000 commented May 19, 2026

View reviewed changes

geethaj1 added 4 commits May 19, 2026 12:49

Add scripts for branch-vs-main comparison and intervention testing

eb4f886

deleting old set_uvc code that has been commented out

47c4a66

removing commented out code

fc354b8

	far_uvc_workplace_max_efficacy = NULL, # sigmoid
	far_uvc_workplace_max_efficacy = NULL, # sigmoid

	far_uvc_school_max_efficacy = NULL, # sigmoid
	far_uvc_school_max_efficacy = NULL, # sigmoid

		parameters_list[paste0("far_uvc_", setting_types, "_efficacy")] <- parameters_list$far_uvc_joint_efficacy
		parameters_list[paste0("far_uvc_", setting_types, "_timestep")] <- parameters_list$far_uvc_joint_timestep



		# =============================================================================
		# Helper functions for ACH / efficacy / UV-C conversions

Conversation

cwhittaker1000 commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cwhittaker1000 commented Jan 22, 2026

Uh oh!

geethaj1 commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

geethaj1 commented Feb 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

cwhittaker1000 commented May 19, 2026

Uh oh!

cwhittaker1000 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cwhittaker1000 commented Jan 22, 2026 •

edited

Loading

geethaj1 commented Feb 11, 2026 •

edited

Loading