refactor(api)!: remove float-based numeric/vector overloads for determinism

Author: mrdav30

src/FixedMathSharp/Numerics/Vector2d.cs

@@ -91,8 +91,6 @@ public partial struct Vector2d : IEquatable<Vector2d>, IComparable<Vector2d>, IE
 
     public Vector2d(int xInt, int yInt) : this((Fixed64)xInt, (Fixed64)yInt) { }
 
-    public Vector2d(float xFloat, float yFloat) : this((Fixed64)xFloat, (Fixed64)yFloat) { }
-
     public Vector2d(double xDoub, double yDoub) : this((Fixed64)xDoub, (Fixed64)yDoub) { }
 
     [JsonConstructor]
@@ -895,18 +893,6 @@ public static Vector2d ToRadians(Vector2d degrees)
         return v1 + v2;
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static Vector2d operator +(Vector2d v1, (float x, float y) v2)
-    {
-        return new Vector2d(v1.x + v2.x, v1.y + v2.y);
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static Vector2d operator +((float x, float y) v1, Vector2d v2)
-    {
-        return v2 + v1;
-    }
-
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static Vector2d operator -(Vector2d v1, Vector2d v2)
     {
@@ -937,18 +923,6 @@ public static Vector2d ToRadians(Vector2d degrees)
         return new Vector2d(v1.x - v2.x, v1.y - v2.y);
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static Vector2d operator -(Vector2d v1, (float x, float y) v2)
-    {
-        return new Vector2d(v1.x - v2.x, v1.y - v2.y);
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static Vector2d operator -((float x, float y) v1, Vector2d v2)
-    {
-        return new Vector2d(v1.x - v2.x, v1.y - v2.y);
-    }
-
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static Vector2d operator -(Vector2d v1)
     {

src/FixedMathSharp/Numerics/Vector3d.cs

@@ -1074,18 +1074,6 @@ public static Vector3d InverseRotate(Vector3d source, Vector3d position, FixedQu
         return v1 + v2;
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static Vector3d operator +(Vector3d v1, (float x, float y, float z) v2)
-    {
-        return new Vector3d(v1.x + v2.x, v1.y + v2.y, v1.z + v2.z);
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static Vector3d operator +((float x, float y, float z) v1, Vector3d v2)
-    {
-        return v2 + v1;
-    }
-
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static Vector3d operator -(Vector3d v1, Vector3d v2)
     {
@@ -1116,18 +1104,6 @@ public static Vector3d InverseRotate(Vector3d source, Vector3d position, FixedQu
         return new Vector3d(v1.x - v2.x, v1.y - v2.y, v1.z - v2.z);
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static Vector3d operator -(Vector3d v1, (float x, float y, float z) v2)
-    {
-        return new Vector3d(v1.x - v2.x, v1.y - v2.y, v1.z - v2.z);
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static Vector3d operator -((float x, float y, float z) v1, Vector3d v2)
-    {
-        return new Vector3d(v1.x - v2.x, v1.y - v2.y, v1.z - v2.z);
-    }
-
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static Vector3d operator -(Vector3d v1)
     {

tests/FixedMathSharp.Tests/Vector2d.Tests.cs

@@ -572,12 +572,8 @@ public void OperatorOverloads_WithTuplesFloatsAndUnaryMinus_WorkCorrectly()
         Assert.Equal(new Vector2d(2, 3), Fixed64.One + vector);
         Assert.Equal(new Vector2d(4, 6), vector + (3, 4));
         Assert.Equal(new Vector2d(4, 6), (3, 4) + vector);
-        Assert.Equal(new Vector2d(new Fixed64(1.5), new Fixed64(3.5)), vector + (0.5f, 1.5f));
-        Assert.Equal(new Vector2d(new Fixed64(1.5), new Fixed64(3.5)), (0.5f, 1.5f) + vector);
         Assert.Equal(new Vector2d(-2, -2), vector - (3, 4));
         Assert.Equal(new Vector2d(2, 2), (3, 4) - vector);
-        Assert.Equal(new Vector2d(new Fixed64(0.5), new Fixed64(0.5)), vector - (0.5f, 1.5f));
-        Assert.Equal(new Vector2d(new Fixed64(-0.5), new Fixed64(-0.5)), (0.5f, 1.5f) - vector);
         Assert.Equal(new Vector2d(-1, -2), -vector);
         Assert.Equal(new Vector2d(2, 4), vector * new Fixed64(2));
         Assert.Equal(new Vector2d(2, 6), vector * new Vector2d(2, 3));

tests/FixedMathSharp.Tests/Vector3d.Tests.cs

@@ -751,12 +751,8 @@ public void OperatorOverloads_WithScalarsTuplesFloatsAndComponentArithmetic_Work
         Assert.Equal(new Vector3d(2, 3, 4), Fixed64.One + vector);
         Assert.Equal(new Vector3d(4, 6, 8), vector + (3, 4, 5));
         Assert.Equal(new Vector3d(4, 6, 8), (3, 4, 5) + vector);
-        Assert.Equal(new Vector3d(new Fixed64(1.5), new Fixed64(3.5), new Fixed64(5.5)), vector + (0.5f, 1.5f, 2.5f));
-        Assert.Equal(new Vector3d(new Fixed64(1.5), new Fixed64(3.5), new Fixed64(5.5)), (0.5f, 1.5f, 2.5f) + vector);
         Assert.Equal(new Vector3d(-2, -2, -2), vector - (3, 4, 5));
         Assert.Equal(new Vector3d(2, 2, 2), (3, 4, 5) - vector);
-        Assert.Equal(new Vector3d(new Fixed64(0.5), new Fixed64(0.5), new Fixed64(0.5)), vector - (0.5f, 1.5f, 2.5f));
-        Assert.Equal(new Vector3d(new Fixed64(-0.5), new Fixed64(-0.5), new Fixed64(-0.5)), (0.5f, 1.5f, 2.5f) - vector);
         Assert.Equal(new Vector3d(-1, -2, -3), -vector);
         Assert.Equal(new Vector3d(2, 4, 6), vector * new Fixed64(2));
         Assert.Equal(new Vector3d(2, 4, 6), new Fixed64(2) * vector);