Add Material 3 NavigationBar and NavigationBarItem as content emitters#632
Merged
Merged
Conversation
mrmans0n
pushed a commit
that referenced
this pull request
May 19, 2026
Add the following Material 3 chips to `ComposableEmittersList`: `AssistChip`, `ElevatedAssistChip`, `FilterChip`, `ElevatedFilterChip`, `InputChip`, `SuggestionChip`, `ElevatedSuggestionChip`. Mirrors the shape of #613 (Material 3 dividers) and #632 (Material 3 `NavigationBar` / `NavigationBarItem`). Without these entries, `MultipleContentEmitters` and `ModifierNotUsedAtRoot` rely on the `containsComposablesWithModifiers()` fallback in `KtCallExpression.emitsContent`, which only matches when the call site passes a `modifier` argument. Calls like `AssistChip { ... }` (no explicit modifier forwarded) currently slip through. Adding the names to the emitters list closes that gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Material 3
NavigationBarandNavigationBarItemtoComposableEmittersList. These are the Material 3 equivalents ofNavigationRail/NavigationRailItem(already listed in the Material 2 section) and the Material 2BottomNavigation(already listed in the Accompanist section). Mirrors the shape of #613, which added the Material 3 dividers.Without these entries,
MultipleContentEmittersandModifierNotUsedAtRootrely on thecontainsComposablesWithModifiers()fallback inKtCallExpression.emitsContent— which only matches when the call site passes amodifierargument. Calls likeNavigationBar { … }(no explicit modifier forwarded) currently slip through. Adding the names to the emitters list closes that gap.