fix: validate negative deep option values#501
Open
abhu85 wants to merge 1 commit into
Open
Conversation
Throw a TypeError when the `deep` option is set to a negative value, as negative depth doesn't make logical sense and can lead to unexpected behavior in consuming code. Fixes mrmlnc#500 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds validation for the
deepoption to throw aTypeErrorwhen a negative value is provided.Fixes #500
Problem
Currently,
fast-globaccepts negative values for thedeepoption without any error or warning, even though negative depth doesn't make logical sense:This can lead to:
Solution
Add validation at the start of the
Settingsconstructor to throw aTypeErrorwhendeepis negative:Test plan
deepvalues (-1, -10)Notes
The build currently has a pre-existing issue with
fdirand@types/picomatchdependencies (TS1259 error). The new tests follow the existing test patterns and were verified manually withts-node.