chore(*): Update tsconfig

Author: mrmlnc

package.json

@@ -70,6 +70,7 @@
     "@types/node": "^8.0.20",
     "mocha": "^3.5.0",
     "tslint": "^5.6.0",
+    "tslint-config-mrmlnc": "^1.0.0",
     "tslint-config-xo": "^1.3.0",
     "typescript": "^2.8.1",
     "vscode": "^1.1.4"

src/extension.ts

@@ -1,7 +1,7 @@
 import * as path from 'path';
 
-import * as vscode from 'vscode';
 import escapeRegExp = require('lodash.escaperegexp');
+import * as vscode from 'vscode';
 
 import * as filepaths from './managers/filepaths';
 import * as fsUtils from './utils/fs';
@@ -12,16 +12,16 @@ import { IPluginSettings } from './types';
 /**
  * Open file after duplicate action.
  */
-async function openFile(filepath: string) {
-	const document = await vscode.workspace.openTextDocument(filepath);
+async function openFile(filepath: string): Promise<vscode.TextEditor> {
+	const document = await (vscode.workspace.openTextDocument(filepath) as Promise<vscode.TextDocument>);
 
 	return vscode.window.showTextDocument(document);
 }
 
 /**
  * Duplicate action.
  */
-async function duplicator(uri: vscode.Uri, settings: IPluginSettings) {
+async function duplicator(uri: vscode.Uri, settings: IPluginSettings): Promise<vscode.TextEditor | undefined> {
 	const oldPath = uri.fsPath;
 	const oldPathParsed = path.parse(oldPath);
 	const oldPathStats = await fsUtils.pathStat(oldPath);
@@ -38,6 +38,7 @@ async function duplicator(uri: vscode.Uri, settings: IPluginSettings) {
 	// If a user tries to copy a file on the same path
 	if (uri.fsPath === newPath) {
 		vscode.window.showErrorMessage('You can\'t copy a file or directory on the same path.');
+
 		return;
 	}
 
@@ -69,19 +70,20 @@ async function duplicator(uri: vscode.Uri, settings: IPluginSettings) {
 	return;
 }
 
-export function activate(context: vscode.ExtensionContext) {
+export function activate(context: vscode.ExtensionContext): void {
 	const command = vscode.commands.registerCommand('duplicate.execute', (uri: vscode.TextDocument | vscode.Uri) => {
+		const settings = vscode.workspace.getConfiguration().get('duplicate') as IPluginSettings;
+
 		if (!uri || !(<vscode.Uri>uri).fsPath) {
 			const editor = vscode.window.activeTextEditor;
 			if (!editor) {
 				return;
 			}
-			uri = editor.document.uri;
-		}
 
-		const settings = vscode.workspace.getConfiguration().get('duplicate') as IPluginSettings;
+			return duplicator(<vscode.Uri>editor.document.uri, settings);
+		}
 
-		duplicator(<vscode.Uri>uri, settings);
+		return duplicator(<vscode.Uri>uri, settings);
 	});
 
 	context.subscriptions.push(command);

src/managers/filepaths.spec.ts

@@ -3,19 +3,18 @@ import * as path from 'path';
 
 import * as manager from './filepaths';
 
-function getBuildedFilepath(oldName: string, newName: string, isFile: boolean, keep: boolean) {
+function getBuildedFilepath(oldName: string, newName: string, isFile: boolean, keep: boolean): string {
 	const oldPath = path.parse(`/Users/name/Documents/${oldName}`);
 
 	return manager.buildFilepath(
 		oldPath,
-		<any>{ isFile: () => isFile },
+		{ isFile: () => isFile } as any, /* tslint:disable-line no-any */
 		newName,
 		{ keepOriginalExtension: keep, openFileAfterCopy: false }
 	);
 }
 
 describe('Managers → Filepaths', () => {
-
 	describe('.buildFilepath', () => {
 		it('should build path to file', () => {
 			const expected = '/Users/name/Documents/test.ts';
@@ -81,5 +80,4 @@ describe('Managers → Filepaths', () => {
 			assert.equal(actual, expected);
 		});
 	});
-
 });

src/managers/filepaths.ts

@@ -1,5 +1,5 @@
-import * as path from 'path';
 import * as fs from 'fs';
+import * as path from 'path';
 
 import { IPluginSettings } from '../types';
 

src/utils/prompt.ts

@@ -1,18 +1,18 @@
 import * as vscode from 'vscode';
 
-export function name(filename: string) {
+export function name(filename: string): Promise<string | undefined> {
 	return vscode.window.showInputBox({
 		placeHolder: 'Enter the new path for the duplicate.',
 		value: filename.split('.').map((el, i) => i === 0 ? `${el}-copy` : el).join('.')
-	});
+	}) as Promise<string | undefined>;
 }
 
-export function overwrite(filepath: string) {
+export function overwrite(filepath: string): Promise<vscode.MessageItem | undefined> {
 	const message = `The path **${filepath}** alredy exists. Do you want to overwrite the existing path?`;
 	const action = {
 		title: 'OK',
 		isCloseAffordance: false
 	};
 
-	return vscode.window.showWarningMessage(message, action);
+	return vscode.window.showWarningMessage(message, action) as Promise<vscode.MessageItem | undefined>;
 }

tslint.json

@@ -1,44 +1,8 @@
 {
-	"extends": [
-		"tslint-config-xo/esnext"
-	],
+	"extends": ["tslint-config-mrmlnc"],
 	"rules": {
-		"object-curly-spacing": false,
-		"ter-arrow-parens": true,
-
-		"adjacent-overload-signatures": true,
-		"member-access": true,
-		"member-ordering": [
-			true,
-			{
-				"order": [
-					"static-field",
-					"instance-field",
-					"constructor",
-					"public-instance-method",
-					"protected-instance-method",
-					"private-instance-method"
-				]
-			}
-		],
-		"no-empty-interface": "true",
-		"no-reference": true,
-		"no-var-requires": true,
-		"typedef-whitespace": [
-			true,
-			{
-				"call-signature": "nospace",
-				"index-signature": "nospace",
-				"parameter": "nospace",
-				"property-declaration": "nospace",
-				"variable-declaration": "nospace"
-			}
-		],
-		"unified-signatures": true,
-		"variable-name": [
-			true,
-			"check-format",
-			"allow-leading-underscore"
-		]
+		"no-require-imports": false,
+		"match-default-export-name": false,
+		"max-file-line-count": false
 	}
 }