fix: Remove dynamic year from copyright in generated files#1131
Merged
Conversation
The year was generated using `new Date().getFullYear()`, causing CI validation failures when the year changes (checked-in files say 2025 but regenerated files say 2026).
|
@mfazekas is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We check in nitrogen generated files and have a GitHub action that verifies they're up to date. Having a dynamic year in those generated files causes CI failures when the year changes, so this PR removes the year from the copyright notice.
Ref: rive-app/rive-nitro-react-native#101 (workaround using
-Iflag in CI)