Fix build on RN 0.81#206
Conversation
|
dope thanks! |
|
Ha, just came to open a PR for this as well - any chance of a release? I'm using |
|
This didn't solve the issue for me, which makes sense because this is an override. I had to append override fun getExportedCustomDirectEventTypeConstants(): MutableMap<String, Any>? {
return MapBuilder.builder<String, Any>()
.put(LoadErrorEvent.EVENT_NAME, MapBuilder.of("registrationName", "onLoadError"))
.put(LoadStartEvent.EVENT_NAME, MapBuilder.of("registrationName", "onLoadStart"))
.put(LoadEndEvent.EVENT_NAME, MapBuilder.of("registrationName", "onLoadEnd"))
.build()
.toMutableMap()
} |
|
@tsatsujnr139 reading this just now - are you sure this doesn't fix the issue? If yes, can you please create a PR with your change instead to make it work? Thanks |
|
Yes quite sure it didn't solve it... I'll gladly create the PR after I test again to be sure |
Thank you! |
|
I am not sure the entire convo. But This PR fixed the issue https://github.com/Jellify-Music/App/blob/main/patches/react-native-blurhash%2B2.1.1.patch We are using the same patch in the app for couple of months now and it is working flawlessly |
|
Yeah, the fix is already good for us. |
Build fails with above error . This should fix it