Skip to content

fix(android): load bundled res/raw assets in release builds #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jslok wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(android): load bundled res/raw assets in release builds #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion android/src/main/java/com/margelo/nitro/tflite/HybridAssetLoader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package com.margelo.nitro.tflite

import androidx.annotation.Keep
import com.facebook.proguard.annotations.DoNotStrip
import com.margelo.nitro.NitroModules
import com.margelo.nitro.core.ArrayBuffer
import com.margelo.nitro.core.Promise
import java.net.URL
Expand All @@ -11,7 +12,21 @@ import java.net.URL
class HybridAssetLoader : HybridAssetLoaderSpec() {
override fun loadAsset(path: String): Promise<ArrayBuffer> {
return Promise.async {
val bytes = URL(path).readBytes()
val bytes = if (path.startsWith("http://") ||
path.startsWith("https://") ||
path.startsWith("file://")) {
URL(path).readBytes()
} else {
// In release builds, RN's AssetSourceResolver returns a bare Android
// resource identifier (e.g. "app_assets_yolo_nas_pose_n_320_gpu_fp16")
// for non-drawable extensions packaged into res/raw. java.net.URL cannot
// read these — resolve via the app Context / Resources instead.
val ctx = NitroModules.applicationContext
?: throw IllegalStateException("No ReactApplicationContext available to resolve asset: $path")
val resId = ctx.resources.getIdentifier(path, "raw", ctx.packageName)
if (resId == 0) throw IllegalArgumentException("Asset not found in res/raw: $path")
ctx.resources.openRawResource(resId).use { it.readBytes() }
}
return@async ArrayBuffer.copy(bytes)
}
}
Expand Down
Loading