harness patch to naturally specify external xctest run, but not sure if AWS accepts a test spec file when its XCUITest …

Author: hannojg

.github/workflows/harness-aws-device.yml

@@ -65,6 +65,8 @@ env:
   HARNESS_IOS_IPA_ARTIFACT_NAME: harness-ios-ipa
   HARNESS_IOS_HARNESS_XCTEST_RUNNER_IPA_ARTIFACT_NAME: harness-xctest-agent-ipa
   HARNESS_IOS_HARNESS_XCTEST_RUNNER_IPA_PATH: apps/simple-camera/ios/build/devicefarm/HarnessXCTestAgentUITests.ipa
+  HARNESS_IOS_XCTEST_UI_TEST_PACKAGE_OUTPUT: apps/simple-camera/ios/build/devicefarm/HarnessXCTestUITestPackage.zip
+  HARNESS_DEVICE_FARM_REPO_ARCHIVE_NAME: react-native-vision-camera.zip
   HARNESS_DEVICE_FARM_TEST_PACKAGE_OUTPUT: devicefarm-test-package.zip
   HARNESS_ANDROID_BUNDLE_ID: com.margelo.nitro.camera.example.simple
   HARNESS_ANDROID_DEVICE_ARCH: ${{ github.event.inputs.device_arch || 'arm64-v8a' }}
@@ -185,7 +187,7 @@ jobs:
           project-arn: ${{ env.HARNESS_DEVICE_FARM_PROJECT_ARN }}
           aws-region: ${{ env.HARNESS_AWS_REGION }}
           file-path: apps/simple-camera/device-farm-tests/AwsTestSpecIOS.yml
-          upload-type: APPIUM_NODE_TEST_SPEC
+          upload-type: XCTEST_UI_TEST_SPEC
           content-type: application/octet-stream
           upload-name: AwsTestSpecIOS-${{ github.run_id }}-${{ github.run_attempt }}.yml
 
@@ -295,16 +297,6 @@ jobs:
           platform: android
           test-step-outcome: ${{ steps.run-test.outcome }}
 
-  # iOS testing on AWS Device Farm is temporarily disabled.
-  # Device Farm has no UI operator to tap through runtime permission dialogs
-  # (Camera, Microphone, Location, etc.), so the app hangs on first launch.
-  # Unlike Android, there is no equivalent to `adb shell pm grant` for iOS, so
-  # we depend on an upcoming React Native Harness feature to pre-grant iOS
-  # permissions. Until that ships, we still build the iOS app here as a
-  # compile-only smoke test (and to keep the DerivedData/Pods caches warm), but
-  # we do NOT schedule any Device Farm run.
-  # TODO: Re-enable iOS Device Farm testing once Harness ships iOS permission
-  # pre-granting.
   build-ios:
     name: Build iOS
     runs-on: macos-latest
@@ -510,6 +502,38 @@ jobs:
       - name: Verify Harness XCTest UI runner IPA artifact
         run: test -f ${{ env.HARNESS_IOS_HARNESS_XCTEST_RUNNER_IPA_PATH }}
 
+      - name: Create XCTest UI test package
+        run: |
+          set -euo pipefail
+
+          PACKAGE_PATH="${{ env.HARNESS_IOS_XCTEST_UI_TEST_PACKAGE_OUTPUT }}"
+          PACKAGE_ROOT="$(mktemp -d)"
+          REPO_ARCHIVE="$PACKAGE_ROOT/${{ env.HARNESS_DEVICE_FARM_REPO_ARCHIVE_NAME }}"
+          RUNNER_IPA="$PACKAGE_ROOT/$(basename "${{ env.HARNESS_IOS_HARNESS_XCTEST_RUNNER_IPA_PATH }}")"
+
+          rm -f "$PACKAGE_PATH"
+          mkdir -p "$(dirname "$PACKAGE_PATH")"
+
+          git archive \
+            --format=zip \
+            --output "$REPO_ARCHIVE" \
+            HEAD
+
+          cp "${{ env.HARNESS_IOS_HARNESS_XCTEST_RUNNER_IPA_PATH }}" "$RUNNER_IPA"
+
+          (
+            cd "$PACKAGE_ROOT"
+            zip -qry "$GITHUB_WORKSPACE/$PACKAGE_PATH" \
+              "$(basename "$RUNNER_IPA")" \
+              "${{ env.HARNESS_DEVICE_FARM_REPO_ARCHIVE_NAME }}"
+          )
+
+          unzip -tq "$PACKAGE_PATH"
+          unzip -l "$PACKAGE_PATH"
+
+      - name: Verify XCTest UI test package
+        run: test -f ${{ env.HARNESS_IOS_XCTEST_UI_TEST_PACKAGE_OUTPUT }}
+
       - name: Configure AWS credentials
         uses: aws-actions/configure-aws-credentials@v6
         with:
@@ -527,16 +551,16 @@ jobs:
           content-type: application/octet-stream
           upload-name: simple-camera-${{ github.run_id }}-${{ github.run_attempt }}.ipa
 
-      - name: Upload Harness XCTest UI runner IPA to AWS Device Farm
-        id: upload-xctest-runner
+      - name: Upload XCTest UI test package to AWS Device Farm
+        id: upload-xctest-ui-package
         uses: ./.github/actions/upload-devicefarm-artifact
         with:
           project-arn: ${{ env.HARNESS_DEVICE_FARM_PROJECT_ARN }}
           aws-region: ${{ env.HARNESS_AWS_REGION }}
-          file-path: ${{ env.HARNESS_IOS_HARNESS_XCTEST_RUNNER_IPA_PATH }}
-          upload-type: IOS_APP
-          content-type: application/octet-stream
-          upload-name: ${{ env.HARNESS_IOS_HARNESS_XCTEST_RUNNER_IPA_ARTIFACT_NAME }}-${{ github.run_id }}-${{ github.run_attempt }}.ipa
+          file-path: ${{ env.HARNESS_IOS_XCTEST_UI_TEST_PACKAGE_OUTPUT }}
+          upload-type: XCTEST_UI_TEST_PACKAGE
+          content-type: application/zip
+          upload-name: harness-xctest-ui-package-${{ github.run_id }}-${{ github.run_attempt }}.zip
 
       - name: Schedule Device Farm iOS Automated Test
         id: run-test
@@ -548,14 +572,9 @@ jobs:
               "projectArn": "${{ env.HARNESS_DEVICE_FARM_PROJECT_ARN }}",
               "appArn": "${{ steps.upload-ipa.outputs['upload-arn'] }}",
               "devicePoolArn": "${{ env.HARNESS_DEVICE_FARM_IOS_DEVICE_POOL_ARN }}",
-              "configuration": {
-                "auxiliaryApps": [
-                  "${{ steps.upload-xctest-runner.outputs['upload-arn'] }}"
-                ]
-              },
               "test": {
-                "type": "APPIUM_NODE",
-                "testPackageArn": "${{ needs.prepare-devicefarm-assets.outputs.test_package_arn }}",
+                "type": "XCTEST_UI",
+                "testPackageArn": "${{ steps.upload-xctest-ui-package.outputs['upload-arn'] }}",
                 "testSpecArn": "${{ needs.prepare-devicefarm-assets.outputs.ios_test_spec_arn }}"
               }
             }

apps/simple-camera/device-farm-tests/AwsTestSpecIOS.yml

@@ -7,38 +7,115 @@ phases:
     commands:
       - devicefarm-cli use node 20
       - node -v
+      - xcodebuild -version
       - curl -fsSL https://bun.com/install | bash
-      - ~/.bun/bin/bun install
       - xcrun devicectl list devices
 
+      # The XCTEST_UI package contains the Harness XCTest runner IPA and a
+      # repo archive. Unpack the repo so the Node/Bun Harness tests can run.
+      - |
+        set -euo pipefail
+
+        REPO_ARCHIVE="$DEVICEFARM_XCTEST_BUILD_DIRECTORY/react-native-vision-camera.zip"
+        HARNESS_REPO_ROOT="$WORKING_DIRECTORY/react-native-vision-camera"
+
+        test -f "$REPO_ARCHIVE"
+        rm -rf "$HARNESS_REPO_ROOT"
+        mkdir -p "$HARNESS_REPO_ROOT"
+        unzip -q "$REPO_ARCHIVE" -d "$HARNESS_REPO_ROOT"
+
+        cd "$HARNESS_REPO_ROOT"
+        ~/.bun/bin/bun install --frozen-lockfile
+
   test:
     commands:
       - HARNESS_JUNIT="$WORKING_DIRECTORY/harness-results.junit.xml"
       - HARNESS_LOG="$WORKING_DIRECTORY/harness-output.log"
 
-      # Resolve host IPv6 for Metro. On macOS runners ipv4 won't work, as confirmed by AWS support.
-      # AWS specifically recommends using the utun interfaces for this, which is what we do here. 
-      # If we fail to resolve an IP address, we error out, as without this the tests won't be able to connect to Metro at all.
+      # Resolve host IPv6 for Metro. On macOS runners IPv4 won't work, as
+      # confirmed by AWS support. AWS recommends utun interfaces for this.
       - |
+        set -euo pipefail
+
         METRO_HOST_IP="$(ifconfig utun1 2>/dev/null | awk '/inet6 / {ip=$2} END {print ip}')"
         if [ -z "$METRO_HOST_IP" ]; then
           METRO_HOST_IP="$(ifconfig utun0 2>/dev/null | awk '/inet6 / {ip=$2} END {print ip}')"
         fi
+
         METRO_HOST_IP="${METRO_HOST_IP%%%*}"
-        [ -n "$METRO_HOST_IP" ] || { echo "Failed to resolve Metro host IPv6." >&2; exit 1; }
+        if [ -z "$METRO_HOST_IP" ]; then
+          echo "Failed to resolve Metro host IPv6." >&2
+          exit 1
+        fi
+
         echo "Using Metro host IPv6 for iOS harness: ${METRO_HOST_IP}"
         echo "$METRO_HOST_IP" > "$WORKING_DIRECTORY/metro-host-ip.txt"
 
-      # Find the physical device connected to this runner we want to run the test on:
-      - IOS_DEVICE_UDID="${DEVICEFARM_DEVICE_UDID:-${DEVICEFARM_DEVICE_NAME:-}}"
-      - IOS_DEVICES_JSON="$(mktemp)"
-      - xcrun devicectl list devices --json-output "$IOS_DEVICES_JSON"
-      - IOS_DEVICE_NAME="$(node -e "const fs=require('node:fs');const payload=JSON.parse(fs.readFileSync(process.argv[1],'utf8'));const devices=payload?.result?.devices ?? [];const udid=process.env.IOS_DEVICE_UDID || '';const matchedByUdid=devices.find((d)=>d?.identifier===udid);const selected=matchedByUdid ?? devices[0] ?? null;const name=selected?.deviceProperties?.name ?? '';if(!name){process.exit(1)};process.stdout.write(name);" "$IOS_DEVICES_JSON")"
-      - 'echo "Resolved Device Farm iOS device for harness: ${IOS_DEVICE_NAME} (${IOS_DEVICE_UDID:-unknown-udid})"'
+      # Find the physical device connected to this runner.
+      - |
+        set -euo pipefail
+
+        IOS_DEVICE_UDID="${DEVICEFARM_DEVICE_UDID:-${DEVICEFARM_DEVICE_NAME:-}}"
+        IOS_DEVICES_JSON="$(mktemp)"
+        xcrun devicectl list devices --json-output "$IOS_DEVICES_JSON"
+
+        IOS_DEVICE_NAME="$(
+          IOS_DEVICE_UDID="$IOS_DEVICE_UDID" node - "$IOS_DEVICES_JSON" <<'NODE'
+        const fs = require('node:fs')
+
+        const jsonPath = process.argv[2]
+        const rawJson = fs.readFileSync(jsonPath, 'utf8')
+        const payload = JSON.parse(rawJson)
+        const devices = payload.result.devices
+        const udid = process.env.IOS_DEVICE_UDID || ''
+
+        let selected = null
+        for (const device of devices) {
+          if (device.identifier === udid) {
+            selected = device
+            break
+          }
+        }
+
+        if (selected == null && devices.length > 0) {
+          selected = devices[0]
+        }
+
+        if (selected == null) {
+          process.exit(1)
+        }
+
+        const name = selected.deviceProperties.name
+        if (!name) {
+          process.exit(1)
+        }
+
+        process.stdout.write(name)
+        NODE
+        )"
+
+        echo "$IOS_DEVICE_NAME" > "$WORKING_DIRECTORY/ios-device-name.txt"
+        echo "Resolved Device Farm iOS device for harness: ${IOS_DEVICE_NAME} (${IOS_DEVICE_UDID:-unknown-udid})"
+
+      # Actually run the JS Harness tests. Harness owns the XCTest agent
+      # lifecycle, but uses AWS's generated .xctestrun instead of building one.
+      - |
+        set -o pipefail
+
+        cd "$WORKING_DIRECTORY/react-native-vision-camera/apps/simple-camera"
 
-      # Actually run the test:
-      - cd apps/simple-camera
-      - set -o pipefail; HARNESS_METRO_BIND_HOST="::" HARNESS_IOS_METRO_HOST="$(cat "$WORKING_DIRECTORY/metro-host-ip.txt")" HARNESS_IOS_DEVICE_NAME="$IOS_DEVICE_NAME" HARNESS_DETECT_NATIVE_CRASHES=false CI=true JEST_JUNIT_OUTPUT_FILE="$HARNESS_JUNIT" ~/.bun/bin/bun run test:harness -- --harnessRunner ios --reporters=default --reporters=jest-junit 2>&1 | tee "$HARNESS_LOG"
+        HARNESS_IOS_XCTESTRUN_FILE="$DEVICEFARM_XCUITESTRUN_FILE" \
+          HARNESS_IOS_XCTEST_DERIVED_DATA_PATH="$DEVICEFARM_DERIVED_DATA_PATH" \
+          HARNESS_METRO_BIND_HOST="::" \
+          HARNESS_IOS_METRO_HOST="$(cat "$WORKING_DIRECTORY/metro-host-ip.txt")" \
+          HARNESS_IOS_DEVICE_NAME="$(cat "$WORKING_DIRECTORY/ios-device-name.txt")" \
+          HARNESS_DETECT_NATIVE_CRASHES=false \
+          CI=true \
+          JEST_JUNIT_OUTPUT_FILE="$HARNESS_JUNIT" \
+          ~/.bun/bin/bun run test:harness -- \
+            --harnessRunner ios \
+            --reporters=default \
+            --reporters=jest-junit 2>&1 | tee "$HARNESS_LOG"
 
 artifacts:
   - $WORKING_DIRECTORY

bun.lock

@@ -126,7 +126,8 @@
     }
   },
   "patchedDependencies": {
-    "react-native@0.84.0": "patches/react-native@0.84.0.patch"
+    "react-native@0.84.0": "patches/react-native@0.84.0.patch",
+    "@react-native-harness/platform-apple@1.2.0-rc.1": "patches/@react-native-harness%2Fplatform-apple@1.2.0-rc.1.patch"
   },
   "version": "5.0.9"
 }