chore: Sleep 1s before capturing max-res to prevent 24MP flakiness (#3982)

Apparently the 48MP+ max resolution capture path is a bit flakey on iOS, as AVFoundation internally prepares it asynchronously - no idea why, but it downgrades to 24MP and so the test fails.

However if we call prepareSettings and/or 1s sleep, the it successfully captures 48MP and the test goes green. No idea why or how to fix it, as AVFoundation also documents this as kind of best effort and can silently downgrade...

Author: mrousavy

apps/simple-camera/__tests__/visioncamera.photo.harness.ts

@@ -15,6 +15,9 @@ import type {
 } from 'react-native-vision-camera'
 import { CommonResolutions, VisionCamera } from 'react-native-vision-camera'
 
+const sleep = (ms: number) =>
+  new Promise<void>((resolve) => setTimeout(resolve, ms))
+
 describe('VisionCamera - Photo', () => {
   let factory: CameraDeviceFactory
   let backDevice: CameraDevice
@@ -362,13 +365,16 @@ describe('VisionCamera - Photo', () => {
       expect(reportedShortEdge).toBe(requestedShortEdge)
       expect(reportedLongEdge).toBe(requestedLongEdge)
 
-      // Prepare default settings on the Photo Output before capturing.
-      // This is kinda required for max res capture on iOS as otherwise
-      // the pipeline is not ready for 48MP+ capture (possibly a race
-      // condition inside AVFoundation?) and would give us binned (eg 24MP)
+      // TODO: Figure out why we need prepareSettings + 1s sleep to capture max res????
+      // Prepare default settings on the Photo Output before capturing,
+      // and add an artificial 1 second timeout.
+      // This is for some reason required for max res capture on iOS as
+      // otherwise the pipeline is not ready for 48MP+ capture (possibly a
+      // race condition inside AVFoundation?) and would give us binned (eg 24MP)
       // photos instead - maybe because it tries to give a photo quickly while
       // 48MP is still being warmed up? No idea. Bad DX imo.
       await photoOutput.prepareSettings([{}])
+      await sleep(1000)
 
       const photo = await photoOutput.capturePhoto(
         { flashMode: 'off', enableShutterSound: false },