fix: avoid Android exposure Harness hangs

mrousavy · mrousavy · commit 75a1ba337bd1 · 2026-06-05T18:07:51.000+02:00
diff --git a/.github/actions/collect-devicefarm-results/action.yml b/.github/actions/collect-devicefarm-results/action.yml
@@ -19,6 +19,18 @@ outputs:
   log-file:
     description: Copied harness log file path
     value: ${{ steps.find-harness-log.outputs.log_file }}
+  xcodebuild-log-file:
+    description: Copied iOS XCTest xcodebuild log file path
+    value: ${{ steps.find-xcodebuild-log.outputs.log_file }}
+  customer-artifacts-log-file:
+    description: Copied Device Farm customer artifacts log file path
+    value: ${{ steps.find-customer-artifacts-log.outputs.log_file }}
+  test-spec-output-file:
+    description: Copied Device Farm test spec output log file path
+    value: ${{ steps.find-test-spec-output.outputs.log_file }}
+  test-spec-timestamped-output-file:
+    description: Copied Device Farm timestamped test spec output log file path
+    value: ${{ steps.find-test-spec-timestamped-output.outputs.log_file }}
 
 runs:
   using: composite
@@ -51,6 +63,74 @@ runs:
           "$WORKSPACE_LOG"
         echo "log_file=$WORKSPACE_LOG" >> "$GITHUB_OUTPUT"
 
+    - name: Find Harness XCTest log
+      id: find-xcodebuild-log
+      if: inputs.platform == 'ios'
+      shell: bash
+      run: |
+        set -euo pipefail
+        ARTIFACT_DIR="${{ inputs.artifact-folder }}"
+        WORKSPACE_LOG=".github/test-results/harness-xcodebuild-ios.log"
+        if bash "$GITHUB_ACTION_PATH/../../scripts/find-devicefarm-artifact.sh" \
+          "$ARTIFACT_DIR" \
+          'xcodebuild.log' \
+          "$WORKSPACE_LOG"; then
+          echo "log_file=$WORKSPACE_LOG" >> "$GITHUB_OUTPUT"
+        else
+          echo "log_file=" >> "$GITHUB_OUTPUT"
+        fi
+
+    - name: Find Device Farm customer artifacts log
+      id: find-customer-artifacts-log
+      shell: bash
+      run: |
+        set -euo pipefail
+        ARTIFACT_DIR="${{ inputs.artifact-folder }}"
+        PLATFORM="${{ inputs.platform }}"
+        WORKSPACE_LOG=".github/test-results/devicefarm-customer-artifacts-${PLATFORM}.log"
+        if bash "$GITHUB_ACTION_PATH/../../scripts/find-devicefarm-artifact.sh" \
+          "$ARTIFACT_DIR" \
+          '*-Customer Artifacts Log.txt' \
+          "$WORKSPACE_LOG"; then
+          echo "log_file=$WORKSPACE_LOG" >> "$GITHUB_OUTPUT"
+        else
+          echo "log_file=" >> "$GITHUB_OUTPUT"
+        fi
+
+    - name: Find Device Farm test spec output
+      id: find-test-spec-output
+      shell: bash
+      run: |
+        set -euo pipefail
+        ARTIFACT_DIR="${{ inputs.artifact-folder }}"
+        PLATFORM="${{ inputs.platform }}"
+        WORKSPACE_LOG=".github/test-results/devicefarm-test-spec-output-${PLATFORM}.log"
+        if bash "$GITHUB_ACTION_PATH/../../scripts/find-devicefarm-artifact.sh" \
+          "$ARTIFACT_DIR" \
+          '*-Test spec output.txt' \
+          "$WORKSPACE_LOG"; then
+          echo "log_file=$WORKSPACE_LOG" >> "$GITHUB_OUTPUT"
+        else
+          echo "log_file=" >> "$GITHUB_OUTPUT"
+        fi
+
+    - name: Find Device Farm timestamped test spec output
+      id: find-test-spec-timestamped-output
+      shell: bash
+      run: |
+        set -euo pipefail
+        ARTIFACT_DIR="${{ inputs.artifact-folder }}"
+        PLATFORM="${{ inputs.platform }}"
+        WORKSPACE_LOG=".github/test-results/devicefarm-test-spec-timestamped-output-${PLATFORM}.log"
+        if bash "$GITHUB_ACTION_PATH/../../scripts/find-devicefarm-artifact.sh" \
+          "$ARTIFACT_DIR" \
+          '*-Test spec timestamped output.txt' \
+          "$WORKSPACE_LOG"; then
+          echo "log_file=$WORKSPACE_LOG" >> "$GITHUB_OUTPUT"
+        else
+          echo "log_file=" >> "$GITHUB_OUTPUT"
+        fi
+
     - name: Publish Harness test results
       id: publish-harness-results
       if: steps.find-harness-junit.outputs.junit_file != ''
@@ -77,6 +157,34 @@ runs:
         cat "$LOG_FILE"
         echo "===== End Harness ${PLATFORM} output log ====="
 
+        XCODEBUILD_LOG="${{ steps.find-xcodebuild-log.outputs.log_file }}"
+        if [[ -n "$XCODEBUILD_LOG" && ( "$TEST_STEP_OUTCOME" == "failure" || "$PUBLISH_OUTCOME" == "failure" ) ]]; then
+          echo "===== Harness ${PLATFORM} xcodebuild log ====="
+          cat "$XCODEBUILD_LOG"
+          echo "===== End Harness ${PLATFORM} xcodebuild log ====="
+        fi
+
+        CUSTOMER_ARTIFACTS_LOG="${{ steps.find-customer-artifacts-log.outputs.log_file }}"
+        if [[ -n "$CUSTOMER_ARTIFACTS_LOG" && "$TEST_STEP_OUTCOME" == "failure" ]]; then
+          echo "===== Device Farm ${PLATFORM} customer artifacts log ====="
+          cat "$CUSTOMER_ARTIFACTS_LOG"
+          echo "===== End Device Farm ${PLATFORM} customer artifacts log ====="
+        fi
+
+        TEST_SPEC_OUTPUT="${{ steps.find-test-spec-output.outputs.log_file }}"
+        if [[ -n "$TEST_SPEC_OUTPUT" && "$TEST_STEP_OUTCOME" == "failure" ]]; then
+          echo "===== Device Farm ${PLATFORM} test spec output ====="
+          cat "$TEST_SPEC_OUTPUT"
+          echo "===== End Device Farm ${PLATFORM} test spec output ====="
+        fi
+
+        TEST_SPEC_TIMESTAMPED_OUTPUT="${{ steps.find-test-spec-timestamped-output.outputs.log_file }}"
+        if [[ -n "$TEST_SPEC_TIMESTAMPED_OUTPUT" && "$TEST_STEP_OUTCOME" == "failure" ]]; then
+          echo "===== Device Farm ${PLATFORM} timestamped test spec output ====="
+          cat "$TEST_SPEC_TIMESTAMPED_OUTPUT"
+          echo "===== End Device Farm ${PLATFORM} timestamped test spec output ====="
+        fi
+
         if [[ "$PUBLISH_OUTCOME" == "failure" ]]; then
           echo "Harness test result publication reported failures." >&2
           exit 1
diff --git a/.github/workflows/harness-aws-device.yml b/.github/workflows/harness-aws-device.yml
@@ -35,7 +35,9 @@ on:
       - main
     paths:
       - ".github/workflows/harness-aws-device.yml"
+      - ".github/actions/collect-devicefarm-results/**"
       - ".github/actions/upload-devicefarm-artifact/**"
+      - ".github/scripts/find-devicefarm-artifact.sh"
       - "apps/simple-camera/**"
       - "packages/react-native-vision-camera/**"
       - "packages/react-native-vision-camera-barcode-scanner/**"
@@ -48,7 +50,9 @@ on:
   pull_request:
     paths:
       - ".github/workflows/harness-aws-device.yml"
+      - ".github/actions/collect-devicefarm-results/**"
       - ".github/actions/upload-devicefarm-artifact/**"
+      - ".github/scripts/find-devicefarm-artifact.sh"
       - "apps/simple-camera/**"
       - "packages/react-native-vision-camera/**"
       - "packages/react-native-vision-camera-barcode-scanner/**"
@@ -118,7 +122,9 @@ jobs:
               - '!packages/**/*.@(swift|mm)'
               - 'patches/**'
               - '.github/workflows/harness-aws-device.yml'
+              - '.github/actions/collect-devicefarm-results/**'
               - '.github/actions/upload-devicefarm-artifact/**'
+              - '.github/scripts/find-devicefarm-artifact.sh'
               - 'bun.lock'
               - 'package.json'
 
diff --git a/apps/simple-camera/__tests__/visioncamera.controller.exposure.harness.ts b/apps/simple-camera/__tests__/visioncamera.controller.exposure.harness.ts
@@ -9,17 +9,6 @@ describe('VisionCamera - Controller Exposure', () => {
   let factory: CameraDeviceFactory
   let backDevice: CameraDevice
 
-  const createContinuousOutput = () =>
-    VisionCamera.createFrameOutput({
-      targetResolution: CommonResolutions.HD_16_9,
-      pixelFormat: 'native',
-      enablePreviewSizedOutputBuffers: false,
-      enablePhysicalBufferRotation: false,
-      enableCameraMatrixDelivery: false,
-      allowDeferredStart: false,
-      dropFramesWhileBusy: true,
-    })
-
   beforeAll(async () => {
     await VisionCamera.requestCameraPermission()
     expect(VisionCamera.cameraPermissionStatus).toBe('authorized')
@@ -41,14 +30,10 @@ describe('VisionCamera - Controller Exposure', () => {
       quality: 0.8,
       qualityPrioritization: 'balanced',
     })
-    const frameOutput = createContinuousOutput()
     const [controller] = await session.configure([
       {
         input: backDevice,
-        outputs: [
-          { output: photoOutput, mirrorMode: 'auto' },
-          { output: frameOutput, mirrorMode: 'auto' },
-        ],
+        outputs: [{ output: photoOutput, mirrorMode: 'auto' }],
         constraints: [],
       },
     ])
@@ -84,14 +69,10 @@ describe('VisionCamera - Controller Exposure', () => {
       quality: 0.8,
       qualityPrioritization: 'balanced',
     })
-    const frameOutput = createContinuousOutput()
     const [controller] = await session.configure([
       {
         input: backDevice,
-        outputs: [
-          { output: photoOutput, mirrorMode: 'auto' },
-          { output: frameOutput, mirrorMode: 'auto' },
-        ],
+        outputs: [{ output: photoOutput, mirrorMode: 'auto' }],
         constraints: [],
       },
     ])
diff --git a/packages/react-native-vision-camera/android/src/main/java/com/margelo/nitro/camera/hybrids/HybridCameraController.kt b/packages/react-native-vision-camera/android/src/main/java/com/margelo/nitro/camera/hybrids/HybridCameraController.kt
@@ -191,9 +191,30 @@ class HybridCameraController(
 
   override fun setExposureBias(exposure: Double): Promise<Unit> {
     return Promise.async {
-      camera.cameraControl
-        .setExposureCompensationIndex(exposure.toInt())
-        .await()
+      val exposureIndex = exposure.toInt()
+      val exposureState = camera.cameraInfo.exposureState
+      if (!exposureState.isExposureCompensationSupported) {
+        throw Error("Exposure compensation is not supported on this CameraDevice!")
+      }
+      if (!exposureState.exposureCompensationRange.contains(exposureIndex)) {
+        throw Error(
+          "`exposure` is out of range! Expected value within " +
+            "${exposureState.exposureCompensationRange.lower}...${exposureState.exposureCompensationRange.upper}, received $exposure.",
+        )
+      }
+
+      val result =
+        camera.cameraControl
+          .setExposureCompensationIndex(exposureIndex)
+
+      // CameraX's Future waits for AE convergence, which can legitimately never happen at
+      // extreme exposure compensation values. Once ExposureState reflects our target index,
+      // CameraX has accepted the request and the controller Promise can resolve.
+      if (result.isDone) {
+        result.await()
+      } else if (camera.cameraInfo.exposureState.exposureCompensationIndex != exposureIndex) {
+        throw Error("Failed to set exposure compensation index to $exposureIndex.")
+      }
     }
   }
 
