Skip to content

Commit bc5e871

Browse files
authored
chore: Enable Harness native crash reporting and update to 1.4.0 RC (#3969)
* chore: Enable Harness native crash reporting * use 1.4.0 as impl
1 parent e8eda52 commit bc5e871

5 files changed

Lines changed: 41 additions & 410 deletions

File tree

apps/simple-camera/device-farm-tests/AwsTestSpec.yml

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ phases:
1010
- curl -fsSL https://bun.com/install | bash
1111
- ~/.bun/bin/bun install
1212

13-
- adb reverse tcp:8081 tcp:8081
1413
- adb wait-for-device
1514
- adb devices -l
1615

@@ -19,10 +18,24 @@ phases:
1918
- MANUFACTURER="$(adb shell getprop ro.product.manufacturer | tr -d '\r')"
2019
- MODEL="$(adb shell getprop ro.product.model | tr -d '\r')"
2120
- 'echo "Resolved Device Farm device for harness: ${MANUFACTURER} ${MODEL}"'
22-
- HARNESS_JUNIT="$WORKING_DIRECTORY/harness-results.junit.xml"
23-
- HARNESS_LOG="$WORKING_DIRECTORY/harness-output.log"
24-
- cd apps/simple-camera
25-
- set -o pipefail; HARNESS_ANDROID_DEVICE_MANUFACTURER="$MANUFACTURER" HARNESS_ANDROID_DEVICE_MODEL="$MODEL" CI=true FORCE_COLOR=1 JEST_JUNIT_OUTPUT_FILE="$HARNESS_JUNIT" ~/.bun/bin/bun run test:harness:android -- --reporters=default --reporters=jest-junit --verbose 2>&1 | tee "$HARNESS_LOG"
21+
- HARNESS_ARTIFACTS="$WORKING_DIRECTORY/harness-artifacts"
22+
- HARNESS_JUNIT="$HARNESS_ARTIFACTS/harness-results.junit.xml"
23+
- HARNESS_LOG="$HARNESS_ARTIFACTS/harness-output.log"
24+
- mkdir -p "$HARNESS_ARTIFACTS"
25+
- |
26+
set -euo pipefail
27+
28+
cd apps/simple-camera
29+
30+
HARNESS_ANDROID_DEVICE_MANUFACTURER="$MANUFACTURER" \
31+
HARNESS_ANDROID_DEVICE_MODEL="$MODEL" \
32+
CI=true \
33+
FORCE_COLOR=1 \
34+
JEST_JUNIT_OUTPUT_FILE="$HARNESS_JUNIT" \
35+
~/.bun/bin/bun run test:harness:android -- \
36+
--reporters=default \
37+
--reporters=jest-junit \
38+
--verbose 2>&1 | tee "$HARNESS_LOG"
2639
2740
artifacts:
2841
- $WORKING_DIRECTORY

apps/simple-camera/device-farm-tests/AwsTestSpecIOS.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ phases:
3333
- HARNESS_JUNIT="$HARNESS_ARTIFACTS/harness-results.junit.xml"
3434
- HARNESS_LOG="$HARNESS_ARTIFACTS/harness-output.log"
3535
- HARNESS_METRO_HOST_FILE="$HARNESS_ARTIFACTS/metro-host-ip.txt"
36-
- mkdir -p "$HARNESS_ARTIFACTS"
36+
- mkdir -p "$HARNESS_ARTIFACTS" "$WORKING_DIRECTORY/react-native-vision-camera/apps/simple-camera/.harness/crash-reports"
3737

3838
# Resolve host IPv6 for Metro. On macOS runners IPv4 won't work, as
3939
# confirmed by AWS support. AWS recommends utun interfaces for this.
@@ -68,7 +68,6 @@ phases:
6868
HARNESS_METRO_BIND_HOST="::" \
6969
HARNESS_IOS_METRO_HOST="$(cat "$HARNESS_METRO_HOST_FILE")" \
7070
HARNESS_IOS_DEVICE_ID="$DEVICEFARM_DEVICE_UDID" \
71-
HARNESS_DETECT_NATIVE_CRASHES=false \
7271
CI=true \
7372
FORCE_COLOR=1 \
7473
JEST_JUNIT_OUTPUT_FILE="$HARNESS_JUNIT" \
@@ -80,3 +79,4 @@ phases:
8079
8180
artifacts:
8281
- $WORKING_DIRECTORY/harness-artifacts
82+
- $WORKING_DIRECTORY/react-native-vision-camera/apps/simple-camera/.harness/crash-reports

apps/simple-camera/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@
4747
"@react-native-community/cli": "20.1.3",
4848
"@react-native-community/cli-platform-android": "20.1.3",
4949
"@react-native-community/cli-platform-ios": "20.1.3",
50-
"@react-native-harness/platform-android": "1.3.0",
51-
"@react-native-harness/platform-apple": "1.3.0",
50+
"@react-native-harness/platform-android": "1.4.0-rc.1",
51+
"@react-native-harness/platform-apple": "1.4.0-rc.1",
5252
"@react-native/babel-preset": "0.85.3",
5353
"@react-native/metro-config": "0.85.3",
5454
"@react-native/typescript-config": "0.85.3",
5555
"@types/react": "19.2.15",
56-
"react-native-harness": "1.3.0",
56+
"react-native-harness": "1.4.0-rc.1",
5757
"typescript": "6.0.3",
5858
"yargs": "18.0.0"
5959
},

apps/simple-camera/rn-harness.config.mjs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,6 @@ const bundleStartTimeout = isCI ? 90_000 : 15_000
7474
const bridgeTimeout = isCI ? 120_000 : 45_000
7575
const maxAppRestarts = isCI ? 4 : 2
7676

77-
// TODO: get libimobiledevice on AWS working
78-
const detectNativeCrashes =
79-
process.env.HARNESS_DETECT_NATIVE_CRASHES?.trim().toLowerCase() !== 'false'
80-
8177
const useEmulator = androidDeviceMode === 'emulator'
8278

8379
const androidDevice = useEmulator
@@ -118,7 +114,7 @@ const config = {
118114
bridgeTimeout,
119115
bundleStartTimeout,
120116
maxAppRestarts,
121-
detectNativeCrashes,
117+
detectNativeCrashes: true,
122118
resetEnvironmentBetweenTestFiles: true,
123119
forwardClientLogs: true,
124120
permissions: true,

0 commit comments

Comments
 (0)