Do not use deprecated MapBuilder but use mapOf instead#3619
Closed
cortinico wants to merge 1 commit intomrousavy:mainfrom
Closed
Do not use deprecated MapBuilder but use mapOf instead#3619cortinico wants to merge 1 commit intomrousavy:mainfrom
MapBuilder but use mapOf instead#3619cortinico wants to merge 1 commit intomrousavy:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
This is also a nice-to-have, build would keep on working with the old API still |
Owner
|
Hey - thanks for your PR, I really appreciate it! And sorry for not replying sooner, I was hyper-focused on VisionCamera V5. I believe this is now obsolete, as VisionCamera V5 is on Nitro now - but this would've been a nice fix for the time. I dont know why I didnt see this PR back in September |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
While looking at the source code of this library, I've realized you still use a deprecated
MapBuilderclass.If you're using Kotlin, the reccomendation is to use
mapOffrom Kotlin instead:https://github.com/facebook/react-native/blob/8f0713fd4bfdb8ece5616c9aa47a20ee381b792e/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/common/MapBuilder.kt#L11