Skip to content

fix: improve SkiaCameraCanvas layout handling #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
therealpurplemana wants to merge 1 commit into from
Closed

fix: improve SkiaCameraCanvas layout handling #3668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions package/src/skia/SkiaCameraCanvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React, { useCallback, useState } from 'react'
import { View } from 'react-native'
import type { LayoutChangeEvent, ViewProps } from 'react-native'
import type { CameraProps } from '../types/CameraProps'
import type { ISharedValue } from 'react-native-worklets-core'
Expand Down Expand Up @@ -47,10 +48,12 @@
}, [])

return (
<SkiaProxy.Canvas {...props} onLayout={onLayout} pointerEvents="none">
{children}
<SkiaProxy.Image x={0} y={0} width={width} height={height} fit={resizeMode} image={texture} />
</SkiaProxy.Canvas>
<View {...props} onLayout={onLayout} style={[props.style, { flex: 1 }]}>

Check warning on line 51 in package/src/skia/SkiaCameraCanvas.tsx

View workflow job for this annotation

GitHub Actions / Lint JS (eslint, prettier) 

Inline style: { flex: 1 }
<SkiaProxy.Canvas style={{ width, height }} pointerEvents="none">
{children}
<SkiaProxy.Image x={0} y={0} width={width} height={height} fit={resizeMode} image={texture} />
</SkiaProxy.Canvas>
</View>
)
}

Expand Down