Skip to content

fix(ios): guard unsupportedCaptureOutputClasses against SimCam crash on simulator #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
therealpurplemana wants to merge 1 commit into from
Closed

fix(ios): guard unsupportedCaptureOutputClasses against SimCam crash on simulator #3826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...ive-vision-camera/ios/Extensions/AVFoundation/AVCaptureDevice.Format+supportsOutput.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,15 @@ import Foundation

extension AVCaptureDevice.Format {
func supportsOutput(_ output: AVCaptureOutput) -> Bool {
#if targetEnvironment(simulator)
// SimCam's DummyCaptureDeviceFormat doesn't implement isStreamingDisparitySupported,
// which is called internally by unsupportedCaptureOutputClasses, causing a SIGSEGV
// on the com.margelo.camera.session queue. On simulator all outputs are assumed
// supported since we're using a fake camera anyway.
return true
#else
let targetOutputClass = type(of: output)
return self.unsupportedCaptureOutputClasses.allSatisfy { $0 != targetOutputClass }
#endif
}
}
Loading