fix(ios): Crash when taking a photo on iOS 15#3827
Closed
Developerius wants to merge 1 commit intomrousavy:mainfrom
Closed
fix(ios): Crash when taking a photo on iOS 15#3827Developerius wants to merge 1 commit intomrousavy:mainfrom
Developerius wants to merge 1 commit intomrousavy:mainfrom
Conversation
|
@Developerius is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Thanks for your PR, but should this property really always be Honestly after writing this I feel like it might be best to just leave it untouched by default since iOS <15 is such a small market share nowadays and we can just drop this for a smaller test matrix... |
Owner
|
I merged #3836 now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that occurs on iOS 15 when attempting to capture a photo.
For iOS versions earlier than 16, AVCapturePhotoSettings.isHighResolutionPhotoEnabled is explicitly set. However, this flag requires isHighResolutionCaptureEnabled = true to be configured on the corresponding AVCapturePhotoOutput. Without this, the app crashes at runtime.