feat: add support for specifying a video path#3844
Merged
mrousavy merged 6 commits intomrousavy:mainfrom May 8, 2026
Merged
Conversation
|
@fontesrp is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
mrousavy
requested changes
May 8, 2026
Owner
mrousavy
left a comment
mrousavy
left a comment
There was a problem hiding this comment.
Overall great stuff, thanks for this PR!
Just left a few nitpick comments.
mrousavy
approved these changes
May 8, 2026
…margelo/nitro/camera/hybrids/outputs/HybridVideoOutput.kt
…ng/HybridVideoRecorder.swift
…deoOutput.nitro.ts
Owner
|
We should probably also add Harness tests for this. |
Owner
|
Thanks so much for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying a video path when creating a video output. This was a supported feature on v4 but is missing on v5.