Add start crash reproducer for #3773#4001
Draft
mrousavy wants to merge 10 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<Camera>Harness test that repeatedly replaces outputs/constraints and immediately restarts from lifecycle callbacksSTART_CRASH_FINDINGS.mdCurrent findings
The issue stack proves
AVCaptureSession.startRunning()overlaps AVFoundation/CoreMedia's private configuration-commit notification path onFigCaptureSessionNotificationQueue. VisionCamera serializesconfigure()andstart()on its own queue, so the current root-cause candidate is thatcommitConfiguration()returns before AVFoundation has fully drained its private "make configuration live" work, and the next queuedstartRunning()can race output attachment.I have not reproduced the exact assertion locally yet. The iPhone SE 3rd gen completed roughly 480 cycles without crashing; the iPhone 15 Pro was later locked and denied further launches. The Harness test is intended to make CI the next real-device signal.
Verification
bun run buildbunx tsc --noEmit --project apps/simple-camera/tsconfig.jsongit diff --checkbun --cwd apps/simple-camera react-native bundle --platform ios --dev true --entry-file index.js --bundle-output /tmp/simple-camera-start-crash.bundle --assets-dest /tmp/simple-camera-start-crash-assets --reset-cacheBiome reported only pre-existing unused-variable warnings in
CameraScreen.tsx; the new Harness file had no Biome diagnostics.