ci: make CameraController Harness runs report deterministically#4003
Draft
mrousavy wants to merge 6 commits into
Draft
ci: make CameraController Harness runs report deterministically#4003mrousavy wants to merge 6 commits into
mrousavy wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch is about CI/Harness reporting, not making failing assertions green.
setExposureBias(...)so the native Promise does not wait for CameraX AE convergence after CameraX has already accepted/reflected the compensation index. This made the Android exposure shard report instead of hanging the suite.--forceExitso the testspec returns after Harness/Jest completes..harnessartifact root instead of the optional.harness/crash-reportsleaf. Green iOS runs were still red because Device Farm failed to attach the empty crash-report directory.CI evidence so far
27025967535/ Android at75a1ba33: all 15 suites reported. The controller shards all passed. CI stayed red only because real photo/coordinates/video tests failed.27025967535/ iOS attempt 3 at75a1ba33: all 15 Harness suites passed, but Device Farm marked the wrapper failed. Customer artifact logs showFailed to attach directory .../.harness/crash-reports because it is empty, which this branch now fixes by collecting.harnessinstead.Verification
bunx biome check --write apps/simple-camera/__tests__/README.md apps/simple-camera/__tests__/visioncamera.controller.*.harness.tsbunx biome check --write apps/simple-camera/__tests__/visioncamera.controller.exposure.harness.ts .github/actions/collect-devicefarm-results/action.yml .github/workflows/harness-aws-device.ymlruby -e 'require "yaml"; YAML.load_file("apps/simple-camera/device-farm-tests/AwsTestSpecIOS.yml"); puts "ok"'git diff --checkNotes:
bunx tsc -p apps/simple-camera/tsconfig.json --noEmitstill fails on the existingvisioncamera.barcode-scanner.harness.tsscanCodesInImageAsynctype issue; this branch does not touch that file.