fix(gui): stop pinning balloon/tooltip popups to Wayland's active window

NotificationBalloon and GotItTooltip were separate Qt::Tool top-level
windows positioned via absolute screen coordinates. Wayland gives clients
no global coordinate space and ignores/reinterprets such requests for
toplevels, so the compositor placed them near whatever window currently
had focus instead of the intended anchor (e.g. a balloon anchored to the
main window showing inside an unrelated dialog on top of it).

Both now stay plain child widgets of their anchor, positioned in its
local coordinate space, which needs no protocol-level placement and works
identically on X11 and Wayland.

Also fixes GotItTooltip sizing too small for wrapped body text:
sizeHint() measured height against the layout's pre-resize width instead
of the fixed TOOLTIP_WIDTH about to be applied; now uses
layout()->totalHeightForWidth() at that width.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: mrpilot2

aide/src/gui/notificationballoonhost.cpp

@@ -4,6 +4,7 @@
 
 #include <QEvent>
 #include <QGuiApplication>
+#include <QPoint>
 #include <QScreen>
 #include <QWidget>
 
@@ -101,7 +102,13 @@ NotificationBalloonPlacement NotificationBalloonHost::placement() const
 
 QRect NotificationBalloonHost::anchorRect() const
 {
-    if (m_anchorWidget != nullptr) { return m_anchorWidget->frameGeometry(); }
+    // Balloons are plain child widgets of the anchor (see
+    // NotificationBalloon's constructor), so their geometry is positioned
+    // in the anchor's own local coordinate space, not global screen
+    // coordinates.
+    if (m_anchorWidget != nullptr) {
+        return QRect(QPoint(0, 0), m_anchorWidget->size());
+    }
     if (auto* screen = QGuiApplication::primaryScreen(); screen != nullptr) {
         return screen->availableGeometry();
     }
@@ -171,6 +178,7 @@ void NotificationBalloonHost::relayout(bool animateNewest)
             balloon->slideIn(startPos, targetPos);
         } else {
             balloon->setGeometry(posX, posY, width, height);
+            balloon->raise();
         }
 
         edgeY =

aide/src/gui/widgets/gotittooltip.cpp

@@ -4,15 +4,14 @@
 
 #include <QCoreApplication>
 #include <QEvent>
-#include <QGuiApplication>
 #include <QHBoxLayout>
 #include <QLabel>
+#include <QLayout>
 #include <QList>
 #include <QPainter>
 #include <QPainterPath>
 #include <QPolygon>
 #include <QPushButton>
-#include <QScreen>
 #include <QTimer>
 #include <QToolButton>
 #include <QVBoxLayout>
@@ -174,12 +173,10 @@ GotItTooltip::GotItTooltip(SettingsInterface& settings, const char* id,
     , m_linkButton(new QToolButton(this))
     , m_gotItButton(new QPushButton(tr("Got it"), this))
 {
-    // No WindowStaysOnTopHint: see NotificationBalloon's constructor for why
-    // - it floats above every window on the desktop rather than just this
-    // one, so Alt+Tab to another app left the tooltip stranded on top of
-    // it. showGotIt() reparents this to the target's window once known,
-    // which keeps Qt::Tool's transient-window behaviour scoped to it.
-    setWindowFlags(Qt::FramelessWindowHint | Qt::Tool);
+    // Stays a plain child widget (see NotificationBalloon's constructor for
+    // why): showGotIt() reparents this to the target's window once known,
+    // and a plain child positioned in that window's local coordinate space
+    // needs no window flags and has no Wayland absolute-positioning issue.
     setAttribute(Qt::WA_TranslucentBackground);
     setFixedWidth(TOOLTIP_WIDTH);
 
@@ -325,12 +322,11 @@ void GotItTooltip::showGotIt(QWidget* target, GotItPosition position)
     }
 
     m_target = target;
-    if (auto* window = target->window(); window != nullptr) {
-        // Transient child of the target's own window (see the constructor's
-        // comment): keeps this tooltip above only that window, and moved,
-        // raised, and minimized together with it.
-        setParent(window, windowFlags());
-    }
+    // QWidget::window() is never null (a parentless widget is its own
+    // window), so this always finds a real anchor. Plain child of the
+    // target's own window: keeps this tooltip positioned, raised, and
+    // minimized together with it.
+    setParent(target->window());
     m_position = position;
     applyArrowMargins();
     enqueue();
@@ -432,10 +428,18 @@ void GotItTooltip::positionNearTarget()
 {
     if (m_target.isNull()) { return; }
 
-    const QRect targetRect(m_target->mapToGlobal(QPoint(0, 0)),
+    auto* window = m_target->window();
+    const QRect targetRect(m_target->mapTo(window, QPoint(0, 0)),
                            m_target->size());
-    const int width  = TOOLTIP_WIDTH;
-    const int height = sizeHint().height();
+    const int width = TOOLTIP_WIDTH;
+    // sizeHint().height() alone under-measures the wrapped body label here:
+    // it reflects the layout's current width, which may still be the
+    // widget's pre-resize default rather than the fixed TOOLTIP_WIDTH,
+    // giving a too-short box for the actual wrapped text. Asking the layout
+    // for the height at the width we're about to set avoids that.
+    const int height = layout()->hasHeightForWidth()
+                           ? layout()->totalHeightForWidth(width)
+                           : sizeHint().height();
     resize(width, height);
 
     int posX = targetRect.left();
@@ -460,16 +464,13 @@ void GotItTooltip::positionNearTarget()
         break;
     }
 
-    if (auto* screen = m_target->screen(); screen != nullptr) {
-        const auto avail = screen->availableGeometry();
-        posX             = std::clamp(posX, avail.left() + SCREEN_EDGE_MARGIN,
-                                      std::max(avail.left() + SCREEN_EDGE_MARGIN,
-                                               avail.right() - width - SCREEN_EDGE_MARGIN));
-        posY =
-            std::clamp(posY, avail.top() + SCREEN_EDGE_MARGIN,
-                       std::max(avail.top() + SCREEN_EDGE_MARGIN,
-                                avail.bottom() - height - SCREEN_EDGE_MARGIN));
-    }
+    const QRect avail = window->rect();
+    posX              = std::clamp(posX, avail.left() + SCREEN_EDGE_MARGIN,
+                                   std::max(avail.left() + SCREEN_EDGE_MARGIN,
+                                            avail.right() - width - SCREEN_EDGE_MARGIN));
+    posY              = std::clamp(posY, avail.top() + SCREEN_EDGE_MARGIN,
+                                   std::max(avail.top() + SCREEN_EDGE_MARGIN,
+                                            avail.bottom() - height - SCREEN_EDGE_MARGIN));
 
     move(posX, posY);
 }

aide/src/gui/widgets/notificationballoon.cpp

@@ -117,13 +117,21 @@ NotificationBalloon::NotificationBalloon(NotificationType type,
     , m_closeButton(new QToolButton(this))
     , m_actionsLayout(new QHBoxLayout)
 {
-    // No WindowStaysOnTopHint: that hint floats above every window on the
-    // desktop, not just this app's own window, so switching to another app
-    // (Alt+Tab) left the balloon stranded on top of it. Qt::Tool with a
-    // parent instead makes this a transient child of the parent's window,
-    // so the window manager keeps it above only that window and moves,
-    // raises, and minimizes it together with its owner.
-    setWindowFlags(Qt::FramelessWindowHint | Qt::Tool);
+    if (parent == nullptr) {
+        // No anchor widget available (e.g. headless tests): fall back to
+        // an independent top-level tool window. No WindowStaysOnTopHint:
+        // that hint floats above every window on the desktop, not just
+        // this app's own window.
+        setWindowFlags(Qt::FramelessWindowHint | Qt::Tool);
+    }
+    // Otherwise stay a plain child widget of the anchor. A separate
+    // top-level (even Qt::Tool, transient-for the anchor) requires
+    // requesting absolute screen coordinates to position it, which
+    // Wayland's compositor ignores/reinterprets for toplevels - it placed
+    // the balloon relative to whatever surface currently had focus instead
+    // of the anchor. A plain child positioned in the anchor's local
+    // coordinate space has no such protocol restriction and works
+    // identically on X11 and Wayland.
     setAttribute(Qt::WA_TranslucentBackground);
     setFixedWidth(BALLOON_WIDTH);
 
@@ -256,6 +264,7 @@ void NotificationBalloon::slideIn(const QPoint& fromPos, const QPoint& toPos)
 {
     move(fromPos);
     show();
+    raise();
 
     m_slideAnimation = new QPropertyAnimation(this, "pos", this);
     m_slideAnimation->setDuration(SLIDE_ANIMATION_MS);

aide/src/include/aide/gui/widgets/notificationballoon.hpp

@@ -44,7 +44,8 @@ namespace aide::widgets
 
         /**
          * @brief Show the balloon and slide it from @p fromPos to @p toPos
-         * (both top-left points in global screen coordinates).
+         * (both top-left points in the parent widget's local coordinate
+         * space).
          */
         void slideIn(const QPoint& fromPos, const QPoint& toPos);
 

tests/ut/notificationballoonhosttest.cpp

@@ -31,15 +31,12 @@ using aide::widgets::NotificationBalloon;
 
 namespace
 {
-    std::size_t liveBalloonCount()
+    std::size_t liveBalloonCount(const QWidget& anchor)
     {
-        std::size_t count = 0;
-        for (auto* widget : QApplication::topLevelWidgets()) {
-            if (qobject_cast<NotificationBalloon*>(widget) != nullptr) {
-                ++count;
-            }
-        }
-        return count;
+        return static_cast<std::size_t>(
+            anchor
+                .findChildren<NotificationBalloon*>(Qt::FindDirectChildrenOnly)
+                .size());
     }
 
     Notification makeNotification(HierarchicalId groupId)
@@ -77,9 +74,9 @@ TEST_CASE("A NotificationBalloonHost", "[NotificationBalloonHost]")
             .displayName        = "Build",
             .defaultDisplayType = NotificationDisplayType::Balloon});
 
-        const auto before = liveBalloonCount();
+        const auto before = liveBalloonCount(anchor);
         manager.post(makeNotification(groupId));
-        REQUIRE(liveBalloonCount() == before + 1);
+        REQUIRE(liveBalloonCount(anchor) == before + 1);
     }
 
     SECTION("shows a balloon for a StickyBalloon-routed notification")
@@ -89,9 +86,9 @@ TEST_CASE("A NotificationBalloonHost", "[NotificationBalloonHost]")
             .displayName        = "Build",
             .defaultDisplayType = NotificationDisplayType::StickyBalloon});
 
-        const auto before = liveBalloonCount();
+        const auto before = liveBalloonCount(anchor);
         manager.post(makeNotification(groupId));
-        REQUIRE(liveBalloonCount() == before + 1);
+        REQUIRE(liveBalloonCount(anchor) == before + 1);
     }
 
     SECTION("shows no balloon for a None-routed notification")
@@ -101,16 +98,16 @@ TEST_CASE("A NotificationBalloonHost", "[NotificationBalloonHost]")
             .displayName        = "Build",
             .defaultDisplayType = NotificationDisplayType::None});
 
-        const auto before = liveBalloonCount();
+        const auto before = liveBalloonCount(anchor);
         manager.post(makeNotification(groupId));
-        REQUIRE(liveBalloonCount() == before);
+        REQUIRE(liveBalloonCount(anchor) == before);
     }
 
     SECTION("shows no balloon for an unregistered group")
     {
-        const auto before = liveBalloonCount();
+        const auto before = liveBalloonCount(anchor);
         manager.post(makeNotification(groupId));
-        REQUIRE(liveBalloonCount() == before);
+        REQUIRE(liveBalloonCount(anchor) == before);
     }
 
     SECTION("stacks a balloon per posted notification")
@@ -120,10 +117,10 @@ TEST_CASE("A NotificationBalloonHost", "[NotificationBalloonHost]")
             .displayName        = "Build",
             .defaultDisplayType = NotificationDisplayType::Balloon});
 
-        const auto before = liveBalloonCount();
+        const auto before = liveBalloonCount(anchor);
         manager.post(makeNotification(groupId));
         manager.post(makeNotification(groupId));
-        REQUIRE(liveBalloonCount() == before + 2);
+        REQUIRE(liveBalloonCount(anchor) == before + 2);
     }
 }
 
@@ -153,7 +150,7 @@ TEST_CASE("A NotificationBalloonHost's placement setting",
                 .isValid());
 
         manager.post(makeNotification(groupId));
-        REQUIRE(liveBalloonCount() > 0);
+        REQUIRE(liveBalloonCount(anchor) > 0);
     }
 
     SECTION("honours an explicit corner setting")
@@ -162,8 +159,8 @@ TEST_CASE("A NotificationBalloonHost's placement setting",
             HierarchicalId("notifications")("balloonPlacement"),
             static_cast<int>(NotificationBalloonPlacement::TopLeft));
 
-        const auto before = liveBalloonCount();
+        const auto before = liveBalloonCount(anchor);
         manager.post(makeNotification(groupId));
-        REQUIRE(liveBalloonCount() == before + 1);
+        REQUIRE(liveBalloonCount(anchor) == before + 1);
     }
 }