Support STREAMED response body#25
Merged
Merged
Conversation
Signed-off-by: Mohammad <mohammad.nassar@ibm.com>
Signed-off-by: Mohammad <mohammad.nassar@ibm.com>
Contributor
Author
Contributor
Contributor
Author
Contributor
|
@Mohammad-nassar10 do you have a test that currently fails? and now passes with these changes? |
ronenkat
reviewed
Jun 10, 2026
Signed-off-by: Mohammad <mohammad.nassar@ibm.com>
Contributor
Author
@ronenkat no test that fails on main and passes with this PR, The bug is noticed in real Envoy in STREAMED mode (when we run the benchmark). |
Signed-off-by: Mohammad <mohammad.nassar@ibm.com>
ronenkat
reviewed
Jun 10, 2026
Contributor
|
/approve |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Stacked on #24.
Getting a bug: Without per-chunk acks, Envoy stops forwarding response bytes after the first chunk, which surfaces to clients as
ClientPayloadError: Not enough data to satisfy transfer length header.pkg/handlers/server.go: ack every non-EoS response body chunk so Envoy keeps streaming.pkg/handlers/response.go: always respond to response headers (inSTREAMEDmode Envoy blocks until we ack); on JSON parse failure, fall back toparseSSEResponseBodyso streaming SSE responses still populate the response plugin pipeline;generateEmptyResponseBodyResponsenow returns a single emptyBodyResponsesince the bytes were already forwarded by the per-chunk acks.config/charts/payload-processor/templates/istio.yaml: switchresponse_body_modeto STREAMED so Istio actually installs theEnvoyFilter.Which issue(s) this PR fixes:
Fixes #
Release note (write
NONEif no user-facing change):