Add configurable staleness decay shared by TTFT and TPOT scorers#37
Open
Mohammad-nassar10 wants to merge 9 commits into
Open
Add configurable staleness decay shared by TTFT and TPOT scorers#37Mohammad-nassar10 wants to merge 9 commits into
Mohammad-nassar10 wants to merge 9 commits into
Conversation
Signed-off-by: Mohammad <mohammad.nassar@ibm.com>
Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
Signed-off-by: Mohammad Nassar <mohammad.nassar@ibm.com>
|
Your PR is large. Please consider breaking it into multiple PRs. The |
|
Your PR is large. Please consider breaking it into multiple PRs. The |
Contributor
Author
|
/cc @ronenkat |
Signed-off-by: Mohammad-nassar10 <79787844+Mohammad-nassar10@users.noreply.github.com>
Signed-off-by: Mohammad <mohammad.nassar@ibm.com>
|
Your PR is large. Please consider breaking it into multiple PRs. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Extracts the staleness-decay logic out of
avg-ttft-scorerinto a sharedinternal/decaypackage and wires bothavg-ttft-scorerandavg-tpot-scorerto it.Stacked on #13.
Which issue(s) this PR fixes:
Fixes #41.
Release note (write
NONEif no user-facing change):