Skip to content

Adds CostDigest t-digest data structure to the pricing package#42

Merged
github-actions[bot] merged 2 commits into
ms-llmd:mainfrom
davidbreitgand:tdigest
Jun 12, 2026
Merged

Adds CostDigest t-digest data structure to the pricing package#42
github-actions[bot] merged 2 commits into
ms-llmd:mainfrom
davidbreitgand:tdigest

Conversation

@davidbreitgand

Copy link
Copy Markdown
Contributor

What type of PR is this?

Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>
Comment thread pkg/framework/interface/datalayer/pricing/cost_digest.go
@@ -0,0 +1,99 @@
/*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these test verifies that the library clone() works as expected they should not be included here, and should be removed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the tests for now. They probably will creep back as CostDigest will include a warmup/exploration counter. But we can defer this discussion.

@davidbreitgand

Copy link
Copy Markdown
Contributor Author

Hi @ronenkat , @Mohammad-nassar10 , the follow-up work for this feature is ready. Since it builds directly on top of this branch, I have it staged in my fork for visibility and allow for your comments: requestcostmetadata.
Once PR#42 is approved and merged, I will retarget the new dependent PR to the main repo.

Thank you.

Signed-off-by: David Breitgand <davidbreitgand@users.noreply.github.com>
@github-actions github-actions Bot added size/M and removed size/L labels Jun 11, 2026
@ronenkat

Copy link
Copy Markdown
Contributor

@davidbreitgand please fix the CI error

@ronenkat

Copy link
Copy Markdown
Contributor

Lets merge after it passes CI

@ronenkat

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@github-actions github-actions Bot added the lgtm label Jun 12, 2026
@github-actions github-actions Bot merged commit b75cf4d into ms-llmd:main Jun 12, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants