Skip to content

Commit feeae8f

Browse files
committed
fix cargo macros and improve check step trigger doc
1 parent e73d72b commit feeae8f

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

Cargo.toml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,10 @@ keywords = ["concourse", "concourseresource", "githubissues"]
1111
categories = ["api-bindings"]
1212
exclude = [".circleci", ".github", ".gitignore", "Dockerfile"]
1313

14-
[dev-dependencies]
15-
tokio = { version = "1", features = ["macros"] }
16-
1714
[dependencies]
1815
octocrab = "0.49"
1916
concourse-resource = "0.3"
20-
tokio = { version = "1.0", features = ["rt-multi-thread"] }
17+
tokio = { version = "1.0", features = ["rt-multi-thread", "macros"] }
2118
serde = "1.0"
2219
serde_json = "1.0"
2320
log = "0.4"

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ version:
4747
4848
### `check`: returns size two list for closed Github issues and size one list for open Github issues
4949

50-
The `check` step determines the state of the specified Github issue. If the state is `closed` (default behavior; otherwise `trigger` source parameter value) then the returned list of versions is size two. If the state is `open` (default behavior; otherwise NOT `trigger` source parameter value) then the returned list of versions is size one. This is specifically to trigger pipelines based on the issue state (`closed` triggers and `open` does not trigger by default; otherwise customized by `trigger` source parameter value) because it simulates a delta of versions for `closed` and not `open` (default). The actual returns are the following (note the states' serialization is implemented by Octocrab to be lowercase strings):
50+
The `check` step determines the state of the specified Github issue. If the state is equal to the `trigger` source parameter value (default: `closed`) then the returned list of versions is size two. If the state is not equal to the `trigger` source parameter value (default: `open`) then the returned list of versions is size one. This is specifically to trigger pipelines based on the issue state (`closed` triggers and `open` does not trigger by default; otherwise customized by `trigger` source parameter value) because it simulates a delta of versions for the `trigger` source parameter value. The actual returns are the following (note the states' serialization is implemented by Octocrab to be lowercase strings):
5151

5252
trigger:
5353
```json

0 commit comments

Comments
 (0)