improve testinfra arg string formatting

Author: mschuchard

CHANGELOG.md

@@ -3,6 +3,7 @@
 - Validate minimum version of `pytest`.
 - Add forced short summary configuration to `compact` parameter functionality.
 - Improve Packer `SSHAgentAuth` check.
+- Improve Testinfra argument string formatting.
 
 ### 1.5.2
 - Note in Packer logs when they originate from this plugin.

provisioner/command.go

@@ -171,7 +171,7 @@ func (provisioner *Provisioner) determineExecCmd(ui packer.Ui) (*exec.Cmd, *pack
 		return nil, nil, err
 	}
 	if len(keyword) > 0 {
-		args = append(args, "-k", fmt.Sprintf("\"%s\"", keyword))
+		args = append(args, "-k", keyword)
 	}
 	// marker
 	marker, err := interpolate.Render(provisioner.config.Marker, &provisioner.config.ctx)
@@ -180,7 +180,7 @@ func (provisioner *Provisioner) determineExecCmd(ui packer.Ui) (*exec.Cmd, *pack
 		return nil, nil, err
 	}
 	if len(marker) > 0 {
-		args = append(args, "-m", fmt.Sprintf("\"%s\"", marker))
+		args = append(args, "-m", marker)
 	}
 	// parallel
 	if provisioner.config.Parallel {
@@ -190,7 +190,7 @@ func (provisioner *Provisioner) determineExecCmd(ui packer.Ui) (*exec.Cmd, *pack
 	if provisioner.config.Sudo {
 		args = append(args, "--sudo")
 	} else if len(provisioner.config.SudoUser) > 0 { // sudo_user
-		args = append(args, fmt.Sprintf("\"--sudo-user=%s\"", provisioner.config.SudoUser))
+		args = append(args, fmt.Sprintf("--sudo-user=%s", provisioner.config.SudoUser))
 	}
 
 	// verbose

provisioner/command_test.go

@@ -58,7 +58,7 @@ func TestProvisionerDetermineExecCmd(test *testing.T) {
 		test.Error("determineExecCmd function failed to determine execution directory for basic config")
 		test.Errorf("actual: %s, expected: %s", execCmd.Dir, basicConfig.Chdir)
 	}
-	if !slices.Equal(execCmd.Args, slices.Concat([]string{provisioner.config.PytestPath, fmt.Sprintf("--hosts=ssh://%s@%s:%d", provisioner.generatedData["User"], provisioner.generatedData["Host"], provisioner.generatedData["Port"]), fmt.Sprintf("--ssh-identity-file=%s", provisioner.generatedData["SSHPrivateKeyFile"]), "--ssh-extra-args=\"-o StrictHostKeyChecking=no\"", "--no-header", "--no-summary", "--disable-warnings", "--force-short-summary", "-k", fmt.Sprintf("\"%s\"", provisioner.config.Keyword), "-m", fmt.Sprintf("\"%s\"", provisioner.config.Marker), "-n", "auto", "--sudo", "-vv"}, provisioner.config.TestFiles)) {
+	if !slices.Equal(execCmd.Args, slices.Concat([]string{provisioner.config.PytestPath, fmt.Sprintf("--hosts=ssh://%s@%s:%d", provisioner.generatedData["User"], provisioner.generatedData["Host"], provisioner.generatedData["Port"]), fmt.Sprintf("--ssh-identity-file=%s", provisioner.generatedData["SSHPrivateKeyFile"]), "--ssh-extra-args=\"-o StrictHostKeyChecking=no\"", "--no-header", "--no-summary", "--disable-warnings", "--force-short-summary", "-k", provisioner.config.Keyword, "-m", provisioner.config.Marker, "-n", "auto", "--sudo", "-vv"}, provisioner.config.TestFiles)) {
 		test.Errorf("determineExecCmd function failed to properly determine remote execution command for basic config with SSH communicator: %s", execCmd.String())
 	}
 	if localCmd != nil {